fix(kbutton): remove deprecated icon slot (#2215)

Kong · Jun 15, 2024 · 0b31480 · 0b31480
1 parent 42947a9
commit 0b31480
Show file tree

Hide file tree

Showing 4 changed files with 48 additions and 52 deletions.
diff --git a/sandbox/pages/SandboxButton.vue b/sandbox/pages/SandboxButton.vue
@@ -411,87 +411,84 @@
       />
       <SandboxSectionComponent>
         <div class="horizontal-spacing">
-          <KButton size="large">
-            <template #icon>
-              <AddCircleIcon />
-            </template>
+          <KButton
+            icon
+            size="large"
+          >
+            <AddCircleIcon />
           </KButton>
           <KButton
             appearance="secondary"
+            icon
             size="large"
           >
-            <template #icon>
-              <ProfileIcon />
-            </template>
+            <ProfileIcon />
           </KButton>
           <KButton
             appearance="tertiary"
+            icon
             size="large"
           >
-            <template #icon>
-              <BookIcon />
-            </template>
+            <BookIcon />
           </KButton>
           <KButton
             appearance="danger"
+            icon
             size="large"
           >
-            <template #icon>
-              <DisabledIcon />
-            </template>
+            <DisabledIcon />
           </KButton>
         </div>
         <div class="horizontal-spacing">
-          <KButton>
-            <template #icon>
-              <AddCircleIcon />
-            </template>
+          <KButton icon>
+            <AddCircleIcon />
           </KButton>
-          <KButton appearance="secondary">
-            <template #icon>
-              <ProfileIcon />
-            </template>
+          <KButton
+            appearance="secondary"
+            icon
+          >
+            <ProfileIcon />
           </KButton>
-          <KButton appearance="tertiary">
-            <template #icon>
-              <BookIcon />
-            </template>
+          <KButton
+            appearance="tertiary"
+            icon
+          >
+            <BookIcon />
           </KButton>
-          <KButton appearance="danger">
-            <template #icon>
-              <DisabledIcon />
-            </template>
+          <KButton
+            appearance="danger"
+            icon
+          >
+            <DisabledIcon />
           </KButton>
         </div>
         <div class="horizontal-spacing">
-          <KButton size="small">
-            <template #icon>
-              <AddCircleIcon />
-            </template>
+          <KButton
+            icon
+            size="small"
+          >
+            <AddCircleIcon />
           </KButton>
           <KButton
             appearance="secondary"
+            icon
             size="small"
           >
-            <template #icon>
-              <ProfileIcon />
-            </template>
+            <ProfileIcon />
           </KButton>
           <KButton
             appearance="tertiary"
+            icon
             size="small"
           >
-            <template #icon>
-              <BookIcon />
-            </template>
+            <BookIcon />
           </KButton>
           <KButton
             appearance="danger"
+            icon
             size="small"
           >
-            <template #icon>
-              <DisabledIcon />
-            </template>
+            <DisabledIcon />
           </KButton>
         </div>
       </SandboxSectionComponent>

diff --git a/sandbox/pages/SandboxCatalog.vue b/sandbox/pages/SandboxCatalog.vue
@@ -105,10 +105,11 @@
             Card title
           </template>
           <template #card-actions>
-            <KButton size="small">
-              <template #icon>
-                <KongIcon />
-              </template>
+            <KButton
+              icon
+              size="small"
+            >
+              <KongIcon />
             </KButton>
           </template>
           <template #card-body>

diff --git a/sandbox/pages/SandboxTable/SandboxTableActions.vue b/sandbox/pages/SandboxTable/SandboxTableActions.vue
@@ -3,11 +3,10 @@
     <template #default>
       <KButton
         appearance="tertiary"
+        icon
         size="small"
       >
-        <template #icon>
-          <MoreIcon />
-        </template>
+        <MoreIcon />
       </KButton>
     </template>
     <template #items>

diff --git a/src/components/KTable/ColumnVisibilityMenu.vue b/src/components/KTable/ColumnVisibilityMenu.vue
@@ -14,11 +14,10 @@
           aria-label="Show/Hide Columns"
           class="menu-button"
           data-testid="column-visibility-menu-button"
+          icon
           size="large"
         >
-          <template #icon>
-            <TableColumnsIcon decorative />
-          </template>
+          <TableColumnsIcon decorative />
         </KButton>
       </KTooltip>