Skip to content

Commit

Permalink
fix: address pr feedback
Browse files Browse the repository at this point in the history
  • Loading branch information
portikM committed Oct 16, 2024
1 parent 0b07a34 commit 8d128fd
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 8 deletions.
8 changes: 2 additions & 6 deletions docs/components/table-data.md
Original file line number Diff line number Diff line change
Expand Up @@ -20,9 +20,9 @@ If you are looking for a simpler table component that does not integrate data fe

## Base KTableView Component

KTableData wraps the KTableView component, adding data fetching functionality.
KTableData wraps the KTableView component, adding data fetching functionality.

KTableData supports all [KTableView props](/components/table-view#props) (with the exception of `data` prop, which is replaced with [`fetcher` prop](#fetcher) in KTableData), [slots](/components/table-view#slots) and [events](/components/table-view#events) (with the exception of [pagination events](/components/table-view#pagination-events) which are not emitted by KTableData). `headers` and `hidePaginationWhenOptional` props as well as `update:table-preferences` event are handled slightly differently in KTableData. See below sections for details.
KTableData supports all [KTableView props](/components/table-view#props), except for the `data` prop, which is replaced by the [`fetcher` prop](#fetcher). It also supports [slots](/components/table-view#slots) and [events](/components/table-view#events), except for [pagination events](/components/table-view#pagination-events), which KTableData does not emit. Additionally, the `headers` prop and the `update:table-preferences` event are handled differently in KTableData. See the sections below for more details.

## Props

Expand Down Expand Up @@ -315,10 +315,6 @@ A string that will passed to fetcher function and can be used to modify the API

Set this to `false` to disable ability to sort.

### hidePaginationWhenOptional

Set this to `true` to hide pagination when the table record count is less than or equal to the page size. Defaults to `false`.

## Events

### state
Expand Down
2 changes: 1 addition & 1 deletion docs/components/table-view.md
Original file line number Diff line number Diff line change
Expand Up @@ -701,7 +701,7 @@ A boolean to hide pagination element (defaults to `false`).

### hidePaginationWhenOptional

Set this to `true` to hide pagination when the table record count is less than or equal to the page size. Defaults to `true`.
Set this to `true` to hide pagination when the table record count is less than or equal to the page size. Defaults to `false`.

### rowExpandable

Expand Down
2 changes: 1 addition & 1 deletion src/components/KTableView/KTableView.vue
Original file line number Diff line number Diff line change
Expand Up @@ -424,7 +424,7 @@ const props = withDefaults(defineProps<TableViewProps>(), {
rowExpandable: () => false,
hideHeaders: false,
nested: false,
hidePaginationWhenOptional: true,
hidePaginationWhenOptional: false,
hideToolbar: false,
/**
* KTableData props defaults
Expand Down

0 comments on commit 8d128fd

Please sign in to comment.