Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(kicon): introduce kui tokens [KHCP-7707] #1562

Merged
merged 2 commits into from
Jul 25, 2023
Merged

feat(kicon): introduce kui tokens [KHCP-7707] #1562

merged 2 commits into from
Jul 25, 2023

Conversation

mptap
Copy link
Contributor

@mptap mptap commented Jul 21, 2023

Summary

Addresses https://konghq.atlassian.net/browse/KHCP-7707

Changes:

  • introduces kui- design tokens in KIcon component
  • removes any usage of Kongponents utility classes in KIcon component template (none found)

PR Checklist

  • Conventional Commits all commits follow the conventional commit standards outlined in the main README.
  • Functional: all changes do not break existing APIs and if so, bump major version.
  • Tests pass: check the output of yarn test
  • Naming: the files and the method and prop variables use the same naming conventions as other Kongponents
  • Framework style: abides by the essential rules in Vue's style guide
  • Cleanliness: does not have formatting issues, unused code (e.g., console.logs, debugger), or leftover comments
  • Docs: includes a technically accurate README, uses JSDOC where appropriate

@mptap mptap requested review from adamdehaven, jillztom and a team as code owners July 21, 2023 21:49
@netlify
Copy link

netlify bot commented Jul 21, 2023 •
edited
Loading

✅ Deploy Preview for kongponents ready!

Name Link
🔨 Latest commit df6d0c5
🔍 Latest deploy log https://app.netlify.com/sites/kongponents/deploys/64bf1962e4b8970007d356e2
😎 Deploy Preview https://deploy-preview-1562--kongponents.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mptap mptap self-assigned this Jul 21, 2023
@mptap mptap force-pushed the khcp-7707-kicon-token-replacement branch from 7c238b9 to 5d9de76 Compare July 21, 2023 21:52
adamdehaven
adamdehaven reviewed Jul 25, 2023
View reviewed changes
docs/components/icon.md Show resolved Hide resolved
docs/components/icon.md Show resolved Hide resolved
@mptap mptap merged commit c69c411 into main Jul 25, 2023
5 checks passed
@mptap mptap deleted the khcp-7707-kicon-token-replacement branch July 25, 2023 00:58
kongponents-bot pushed a commit that referenced this pull request Jul 25, 2023
@semantic-release-bot
chore(release): 8.106.0 [skip ci]
a8f5ac5 
# [8.106.0](v8.105.0...v8.106.0) (2023-07-25)

### Features

* **kicon:** introduce kui tokens [KHCP-7707] ([#1562](#1562)) ([c69c411](c69c411))
@kongponents-bot
Copy link
Collaborator

🎉 This PR is included in version 8.106.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamdehaven adamdehaven adamdehaven approved these changes

@jillztom jillztom Awaiting requested review from jillztom jillztom is a code owner

Assignees

@mptap mptap

Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mptap @kongponents-bot @adamdehaven