Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(kskeleton): introduce kui tokens [KHCP-7723] #1572

Merged
merged 2 commits into from
Jul 31, 2023
Merged

feat(kskeleton): introduce kui tokens [KHCP-7723] #1572

merged 2 commits into from
Jul 31, 2023

Conversation

portikM
Copy link
Member

@portikM portikM commented Jul 24, 2023

Summary

Addresses: https://konghq.atlassian.net/browse/KHCP-7723

Changes:

  • introduces kui- design tokens in KSkeleton component
  • removes any usage of Kongponents utility classes in KSkeleton component template

PR Checklist

  • Conventional Commits all commits follow the conventional commit standards outlined in the main README.
  • Functional: all changes do not break existing APIs and if so, bump major version.
  • Tests pass: check the output of yarn test
  • Naming: the files and the method and prop variables use the same naming conventions as other Kongponents
  • Framework style: abides by the essential rules in Vue's style guide
  • Cleanliness: does not have formatting issues, unused code (e.g., console.logs, debugger), or leftover comments
  • Docs: includes a technically accurate README, uses JSDOC where appropriate

@portikM portikM requested a review from a team as a code owner July 24, 2023 19:52
@portikM portikM self-assigned this Jul 24, 2023
@netlify
Copy link

netlify bot commented Jul 24, 2023 •
edited
Loading

✅ Deploy Preview for kongponents ready!

Name Link
🔨 Latest commit 1811cc6
🔍 Latest deploy log https://app.netlify.com/sites/kongponents/deploys/64c7ddc4ef1c02000817e4db
😎 Deploy Preview https://deploy-preview-1572--kongponents.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@portikM portikM force-pushed the feat/khcp-7723-ksceleton-token-replacement branch from 567791b to dcb9fcb Compare July 24, 2023 21:21
portikM
portikM commented Jul 24, 2023
View reviewed changes
src/components/KSkeleton/KSkeletonBox.vue
display: inline-flex;
margin-right: var(--kui-space-20, $kui-space-20) !important;
transition: 1s;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For review: decided to leave some of the values untouched here (animation timing, gradient) as they are very specific to loader component, rather than our UIs so I don't see value in tokenizing those. Open to feedback.

jillztom
jillztom previously approved these changes Jul 28, 2023
View reviewed changes
@portikM portikM force-pushed the feat/khcp-7723-ksceleton-token-replacement branch from dcb9fcb to 1811cc6 Compare July 31, 2023 16:13
@portikM portikM enabled auto-merge (squash) July 31, 2023 16:14
@portikM portikM disabled auto-merge July 31, 2023 16:15
@portikM portikM enabled auto-merge (squash) July 31, 2023 16:15
@portikM portikM merged commit 7d59176 into main Jul 31, 2023
5 checks passed
@portikM portikM deleted the feat/khcp-7723-ksceleton-token-replacement branch July 31, 2023 16:25
kongponents-bot pushed a commit that referenced this pull request Jul 31, 2023
@semantic-release-bot
chore(release): 8.119.0 [skip ci]
b22f16a 
# [8.119.0](v8.118.1...v8.119.0) (2023-07-31)

### Features

* **kcodeblock:** introduce kui tokens [KHCP-7700] ([#1590](#1590)) ([5813d72](5813d72))
* **kskeleton:** introduce kui tokens [KHCP-7723] ([#1572](#1572)) ([7d59176](7d59176))
@kongponents-bot
Copy link
Collaborator

🎉 This PR is included in version 8.119.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jillztom jillztom jillztom approved these changes

@adamdehaven adamdehaven Awaiting requested review from adamdehaven adamdehaven is a code owner

Assignees

@portikM portikM

Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@portikM @kongponents-bot @jillztom