-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(kskeleton): introduce kui tokens [KHCP-7723] #1572
Conversation
✅ Deploy Preview for kongponents ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
567791b
to
dcb9fcb
Compare
display: inline-flex; | ||
margin-right: var(--kui-space-20, $kui-space-20) !important; | ||
transition: 1s; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For review: decided to leave some of the values untouched here (animation timing, gradient) as they are very specific to loader component, rather than our UIs so I don't see value in tokenizing those. Open to feedback.
dcb9fcb
to
1811cc6
Compare
🎉 This PR is included in version 8.119.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Summary
Addresses: https://konghq.atlassian.net/browse/KHCP-7723
Changes:
kui-
design tokens inKSkeleton
componentKSkeleton
component templatePR Checklist