Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(kslideout): introduce kui tokens [khcp-7724] #1586

Merged
merged 3 commits into from
Jul 27, 2023
Merged

feat(kslideout): introduce kui tokens [khcp-7724] #1586

merged 3 commits into from
Jul 27, 2023

Conversation

aanchalm01
Copy link
Contributor

Summary

Addresses:
https://konghq.atlassian.net/browse/KHCP-7724

PR Checklist

  • Conventional Commits all commits follow the conventional commit standards outlined in the main README.
  • Functional: all changes do not break existing APIs and if so, bump major version.
  • Tests pass: check the output of yarn test
  • Naming: the files and the method and prop variables use the same naming conventions as other Kongponents
  • Framework style: abides by the essential rules in Vue's style guide
  • Cleanliness: does not have formatting issues, unused code (e.g., console.logs, debugger), or leftover comments
  • Docs: includes a technically accurate README, uses JSDOC where appropriate

@aanchalm01 aanchalm01 self-assigned this Jul 25, 2023
@aanchalm01 aanchalm01 requested review from adamdehaven, jillztom and a team as code owners July 25, 2023 21:53
@aanchalm01 aanchalm01 enabled auto-merge (squash) July 25, 2023 21:53
@netlify
Copy link

netlify bot commented Jul 25, 2023 •
edited
Loading

✅ Deploy Preview for kongponents ready!

Name Link
🔨 Latest commit 569a095
🔍 Latest deploy log https://app.netlify.com/sites/kongponents/deploys/64c16fcdd56ba700085a9c11
😎 Deploy Preview https://deploy-preview-1586--kongponents.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

portikM
portikM requested changes Jul 26, 2023
View reviewed changes
Copy link
Member

@portikM portikM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You missed couple properties (use $tmp-animation-timing-2 for transition):

Screen Shot 2023-07-26 at 12 07 16 PM

src/components/KSlideout/KSlideout.vue Outdated Show resolved Hide resolved
src/components/KSlideout/KSlideout.vue Outdated Show resolved Hide resolved
@aanchalm01 aanchalm01 requested a review from portikM July 26, 2023 19:11
portikM
portikM approved these changes Jul 26, 2023
View reviewed changes
Copy link
Member

@portikM portikM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@aanchalm01 aanchalm01 merged commit 4c5bca4 into main Jul 27, 2023
5 checks passed
@aanchalm01 aanchalm01 deleted the feat/khcp-7724-kslideout-token-replacement branch July 27, 2023 15:22
kongponents-bot pushed a commit that referenced this pull request Jul 27, 2023
@semantic-release-bot
chore(release): 8.116.0 [skip ci]
32c9ee9 
# [8.116.0](v8.115.0...v8.116.0) (2023-07-27)

### Features

* **kslideout:** introduce kui tokens ([#1586](#1586)) ([4c5bca4](4c5bca4))
* **ktabs:** introduce kui tokens [khcp-7727] ([#1585](#1585)) ([eec9283](eec9283))
@kongponents-bot
Copy link
Collaborator

🎉 This PR is included in version 8.116.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DariaYeremina DariaYeremina DariaYeremina left review comments

@jillztom jillztom jillztom approved these changes

@portikM portikM portikM approved these changes

@adamdehaven adamdehaven Awaiting requested review from adamdehaven adamdehaven is a code owner

Assignees

@aanchalm01 aanchalm01

Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@aanchalm01 @kongponents-bot @jillztom @DariaYeremina @portikM