Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(kstepper): introduce kui tokens [KHCP-7725] #1592

Merged
merged 1 commit into from
Jul 31, 2023

Conversation

portikM
Copy link
Member

@portikM portikM commented Jul 26, 2023

Summary

Addresses: https://konghq.atlassian.net/browse/KHCP-7725

Changes:

  • introduces kui- design tokens in KStepper component
  • removes any usage of Kongponents utility classes in KStepper component template

PR Checklist

  • Conventional Commits all commits follow the conventional commit standards outlined in the main README.
  • Functional: all changes do not break existing APIs and if so, bump major version.
  • Tests pass: check the output of yarn test
  • Naming: the files and the method and prop variables use the same naming conventions as other Kongponents
  • Framework style: abides by the essential rules in Vue's style guide
  • Cleanliness: does not have formatting issues, unused code (e.g., console.logs, debugger), or leftover comments
  • Docs: includes a technically accurate README, uses JSDOC where appropriate

@portikM portikM self-assigned this Jul 26, 2023
@portikM portikM requested review from adamdehaven, jillztom and a team as code owners July 26, 2023 21:59
@netlify
Copy link

netlify bot commented Jul 26, 2023

Deploy Preview for kongponents ready!

Name Link
🔨 Latest commit 042b4ae
🔍 Latest deploy log https://app.netlify.com/sites/kongponents/deploys/64c7cb17ef1c020008114b1c
😎 Deploy Preview https://deploy-preview-1592--kongponents.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

jillztom
jillztom previously approved these changes Jul 28, 2023
@portikM portikM merged commit 3a26b24 into main Jul 31, 2023
5 checks passed
@portikM portikM deleted the feat/khcp-7725-kstepper-token-replacement branch July 31, 2023 15:23
@kongponents-bot
Copy link
Collaborator

🎉 This PR is included in version 8.119.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants