Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(kcard): body line-height in table cells #1596

Merged
merged 1 commit into from
Jul 28, 2023

Conversation

kleinfreund
Copy link
Contributor

Summary

Fixes the line-height of table cells nested inside a KCard body. Currently, the font-size and line-height will be the same pixel value (16px) unless overridden.

Signed-off-by: Philipp Rudloff philipp.rudloff@konghq.com

PR Checklist

  • Conventional Commits all commits follow the conventional commit standards outlined in the main README.
  • Functional: all changes do not break existing APIs and if so, bump major version.
  • Tests pass: check the output of yarn test
  • Naming: the files and the method and prop variables use the same naming conventions as other Kongponents
  • Framework style: abides by the essential rules in Vue's style guide
  • Cleanliness: does not have formatting issues, unused code (e.g., console.logs, debugger), or leftover comments
  • Docs: includes a technically accurate README, uses JSDOC where appropriate

Fixes the line-height of table cells nested inside a KCard body. Currently, the `font-size` and `line-height` will be the same pixel value (16px) unless overridden.

Signed-off-by: Philipp Rudloff <philipp.rudloff@konghq.com>
@netlify
Copy link

netlify bot commented Jul 27, 2023

Deploy Preview for kongponents ready!

Name Link
🔨 Latest commit 9a68017
🔍 Latest deploy log https://app.netlify.com/sites/kongponents/deploys/64c27e725cd16900081c771f
😎 Deploy Preview https://deploy-preview-1596--kongponents.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@kleinfreund kleinfreund merged commit 5eef39b into main Jul 28, 2023
5 checks passed
@kleinfreund kleinfreund deleted the fix/kcard-body-line-height-in-tables branch July 28, 2023 14:19
@kleinfreund kleinfreund removed their assignment Jul 28, 2023
@kongponents-bot
Copy link
Collaborator

🎉 This PR is included in version 8.116.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

kongponents-bot pushed a commit that referenced this pull request Jul 28, 2023
## [8.116.1](v8.116.0...v8.116.1) (2023-07-28)

### Bug Fixes

* **kcard:** body line-height in table cells ([#1596](#1596)) ([5eef39b](5eef39b))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants