Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(kcatalog): emit on card click #1608

Merged
merged 3 commits into from
Aug 2, 2023
Merged

feat(kcatalog): emit on card click #1608

merged 3 commits into from
Aug 2, 2023

Conversation

kaiarrowood
Copy link
Collaborator

@kaiarrowood kaiarrowood commented Aug 1, 2023 •
edited
Loading

Summary

Add an event emission for when a KCatalogItem is clicked.

PR Checklist

  • Conventional Commits all commits follow the conventional commit standards outlined in the main README.
  • Functional: all changes do not break existing APIs and if so, bump major version.
  • Tests pass: check the output of yarn test
  • Naming: the files and the method and prop variables use the same naming conventions as other Kongponents
  • Framework style: abides by the essential rules in Vue's style guide
  • Cleanliness: does not have formatting issues, unused code (e.g., console.logs, debugger), or leftover comments
  • Docs: includes a technically accurate README, uses JSDOC where appropriate

@kaiarrowood kaiarrowood self-assigned this Aug 1, 2023
@netlify
Copy link

netlify bot commented Aug 1, 2023 •
edited
Loading

✅ Deploy Preview for kongponents ready!

Name Link
🔨 Latest commit aac00d3
🔍 Latest deploy log https://app.netlify.com/sites/kongponents/deploys/64ca86822621530008fc6bb7
😎 Deploy Preview https://deploy-preview-1608--kongponents.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ValeryG
Copy link
Collaborator

ValeryG commented Aug 1, 2023

Does what expected - simplifies dealing with Catalog when on card click event needs to be handled. There was nothing like that previously in Catalog component. Here is example of consumer: https://github.com/Kong/konnect-ui-apps/pull/1100

@kaiarrowood kaiarrowood marked this pull request as ready for review August 2, 2023 17:25
@kaiarrowood kaiarrowood enabled auto-merge (squash) August 2, 2023 17:27
portikM
portikM approved these changes Aug 2, 2023
View reviewed changes
Copy link
Member

@portikM portikM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@kaiarrowood kaiarrowood merged commit 8cbe88c into main Aug 2, 2023
5 checks passed
@kaiarrowood kaiarrowood deleted the feat/k-catalog-card-click branch August 2, 2023 17:44
kongponents-bot pushed a commit that referenced this pull request Aug 2, 2023
@semantic-release-bot
chore(release): 8.122.0 [skip ci]
6ae0b9e 
# [8.122.0](v8.121.1...v8.122.0) (2023-08-02)

### Features

* **kcatalog:** emit on card click ([#1608](#1608)) ([8cbe88c](8cbe88c))
@kongponents-bot
Copy link
Collaborator

🎉 This PR is included in version 8.122.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@portikM portikM portikM approved these changes

@adamdehaven adamdehaven Awaiting requested review from adamdehaven adamdehaven is a code owner

@jillztom jillztom Awaiting requested review from jillztom jillztom is a code owner

Assignees

@kaiarrowood kaiarrowood

Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kaiarrowood @ValeryG @kongponents-bot @portikM