Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(*): deprecate klabel help prop #1799

Merged
merged 1 commit into from
Oct 27, 2023
Merged

Conversation

portikM
Copy link
Member

@portikM portikM commented Oct 27, 2023

Summary

Instead of removing help prop in KLabel, deprecate it for backwards compatibility.

PR Checklist

  • Conventional Commits all commits follow the conventional commit standards outlined in the main README.
  • Tests coverage: test coverage was added for new features and bug fixes
  • Docs: includes a technically accurate README

@portikM portikM self-assigned this Oct 27, 2023
@portikM portikM requested a review from a team as a code owner October 27, 2023 17:24
@netlify
Copy link

netlify bot commented Oct 27, 2023

Deploy Preview for kongponents-sandbox ready!

Name Link
🔨 Latest commit e936175
🔍 Latest deploy log https://app.netlify.com/sites/kongponents-sandbox/deploys/653bf233ece4f70008a9613b
😎 Deploy Preview https://deploy-preview-1799--kongponents-sandbox.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Oct 27, 2023

Deploy Preview for kongponents ready!

Name Link
🔨 Latest commit e936175
🔍 Latest deploy log https://app.netlify.com/sites/kongponents/deploys/653bf232fdd3af00085a5c1a
😎 Deploy Preview https://deploy-preview-1799--kongponents.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@portikM portikM enabled auto-merge (squash) October 27, 2023 17:26
@portikM portikM merged commit 001a48e into alpha Oct 27, 2023
6 checks passed
@portikM portikM deleted the fix/klabel-deprecate-help-prop branch October 27, 2023 17:32
kongponents-bot pushed a commit that referenced this pull request Oct 27, 2023
# [9.0.0-alpha.32](v9.0.0-alpha.31...v9.0.0-alpha.32) (2023-10-27)

### Bug Fixes

* deprecate klabel help prop ([#1799](#1799)) ([001a48e](001a48e))
@kongponents-bot
Copy link
Collaborator

🎉 This PR is included in version 9.0.0-alpha.32 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants