Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(*): misc alpha fixes #2207

Merged
merged 3 commits into from
Jun 5, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions .eslintrc.cjs
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
const deprecatedUtilityClasses = require('./deprecated-classes.cjs')

module.exports = {
root: true,
parserOptions: {
Expand Down Expand Up @@ -38,8 +36,6 @@ module.exports = {
'vue/attributes-order': ['error', {
alphabetical: true,
}],
// Disallow Kongponents utility classes
'vue/no-restricted-class': ['error', ...deprecatedUtilityClasses],
'@typescript-eslint/no-explicit-any': 'off',
// Avoids false errors like “'NodeListOf' is not defined”.
'no-undef': 'off',
Expand Down
1 change: 0 additions & 1 deletion .github/CODEOWNERS
Validating CODEOWNERS rules …
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@
# Dev tools
/.eslintrc.js @adamdehaven @jillztom
/.stylelintrc.cjs @adamdehaven @jillztom @portikM
/deprecated-classes.cjs @adamdehaven @jillztom @portikM
/.gitignore @adamdehaven @jillztom @kaiarrowood
/vite.config.ts @adamdehaven @jillztom

Expand Down
289 changes: 0 additions & 289 deletions deprecated-classes.cjs

This file was deleted.

9 changes: 0 additions & 9 deletions sandbox/pages/SandboxBadge.vue
Original file line number Diff line number Diff line change
Expand Up @@ -76,14 +76,6 @@
Long truncating method badge
</KBadge>
</SandboxSectionComponent>
<SandboxSectionComponent title="backgroundColor & color">
<KBadge
:background-color="KUI_COLOR_BACKGROUND_PRIMARY_WEAK"
:color="KUI_COLOR_TEXT_INVERSE"
>
Custom
</KBadge>
</SandboxSectionComponent>
<SandboxSectionComponent title="tooltip">
<KBadge tooltip="I always tooltip">
Truncation unnecessary
Expand Down Expand Up @@ -415,7 +407,6 @@
import { inject } from 'vue'
import SandboxTitleComponent from '../components/SandboxTitleComponent.vue'
import SandboxSectionComponent from '../components/SandboxSectionComponent.vue'
import { KUI_COLOR_BACKGROUND_PRIMARY_WEAK, KUI_COLOR_TEXT_INVERSE } from '@kong/design-tokens'
import { KongIcon, WarningOutlineIcon, CloseIcon } from '@kong/icons'

const handleIconClick = (): void => {
Expand Down
2 changes: 1 addition & 1 deletion src/components/KDateTimePicker/KDateTimePicker.vue
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@
<CalIcon
v-if="icon"
class="calendar-icon"
:color="KUI_COLOR_TEXT_NEUTRAL"
:color="`var(--kui-color-text-neutral, ${KUI_COLOR_TEXT_NEUTRAL})`"
decorative
:size="KUI_ICON_SIZE_40"
/>
Expand Down
2 changes: 1 addition & 1 deletion src/components/KModal/KModal.vue
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@
@click="$emit('cancel')"
>
<CloseIcon
:color="KUI_COLOR_TEXT_NEUTRAL"
:color="`var(--kui-color-text-neutral, ${KUI_COLOR_TEXT_NEUTRAL})`"
decorative
/>
</button>
Expand Down
2 changes: 1 addition & 1 deletion src/components/KSkeleton/KSkeleton.vue
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@
<ProgressIcon
v-else-if="type === 'spinner'"
class="skeleton-spinner"
:color="KUI_COLOR_TEXT_NEUTRAL"
:color="`var(--kui-color-text-neutral, ${KUI_COLOR_TEXT_NEUTRAL})`"
title="Loading"
/>

Expand Down
2 changes: 1 addition & 1 deletion src/components/KSlideout/KSlideout.vue
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@
@click.stop="$emit('close')"
>
<CloseIcon
:color="KUI_COLOR_TEXT_NEUTRAL"
:color="`var(--kui-color-text-neutral, ${KUI_COLOR_TEXT_NEUTRAL})`"
decorative
/>
</button>
Expand Down
6 changes: 3 additions & 3 deletions src/components/KStepper/KStep.vue
Original file line number Diff line number Diff line change
Expand Up @@ -11,19 +11,19 @@
<div class="step-circle">
<CheckIcon
v-if="state === 'completed'"
:color="KUI_COLOR_TEXT_INVERSE"
:color="`var(--kui-color-text-inverse, ${KUI_COLOR_TEXT_INVERSE})`"
:size="KUI_ICON_SIZE_40"
title="Completed"
/>
<ProgressIcon
v-else-if="state === 'pending'"
:color="KUI_COLOR_TEXT_PRIMARY"
:color="`var(--kui-color-text-primary, ${KUI_COLOR_TEXT_PRIMARY})`"
:size="KUI_ICON_SIZE_40"
title="Pending"
/>
<CloseIcon
v-else-if="state === 'error'"
:color="KUI_COLOR_TEXT_INVERSE"
:color="`var(--kui-color-text-inverse, ${KUI_COLOR_TEXT_INVERSE})`"
:size="KUI_ICON_SIZE_40"
title="Error"
/>
Expand Down
Loading
Loading