fix(kfileupload, kselect, kmultiselect): kinput id [KHCP-12336] #2241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for kongponents-sandbox ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for kongponents ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
adamdehaven
reviewed
Jun 18, 2024
Leopoldthecoder
approved these changes
Jun 19, 2024
jillztom
approved these changes
Jun 19, 2024
kongponents-bot
pushed a commit
that referenced
this pull request
Jun 19, 2024
# [9.0.0-alpha.179](v9.0.0-alpha.178...v9.0.0-alpha.179) (2024-06-19) ### Bug Fixes * **kfileupload, kselect, kmultiselect:** kinput id [KHCP-12336] ([#2241](#2241)) ([528280d](528280d))
|
🎉 This PR is included in version 9.0.0-alpha.179 🎉 The release is available on: Your semantic-release bot 📦🚀 |
adamdehaven
reviewed
Jun 19, 2024
| @@ -65,13 +69,16 @@ | |||
| </template> | |||
|
|
|||
| <script lang="ts" setup> | |||
| defineOptions({ | |||
There was a problem hiding this comment.
Shouldn’t this go below the imports?
| } | ||
|
|
||
| watch(fileInputKey, async () => { | ||
| await nextTick() |
There was a problem hiding this comment.
Why does this code need to be in a separate watcher instead of in the one below that triggers the key to increment?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Binding id to KInput in KFileUpload, KSelect and KMultiselect through
v-bind-oncedirective creates a problem where the id gets assigned to the wrong element because the directive ignores theinherritAttrs: falsesetting. That means:Solution: do not rely on
v-bind-oncein said components andonMountedhook assign label for attribute programatically based on value of input id attributePR Checklist