-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(*): fixable eslint-plugin-vuejs-accessibility issues [KHCP-11024] #2345
Merged
portikM
merged 9 commits into
main
from
fix/khcp-11024-eslint-plugin-vuejs-accessibility
Aug 21, 2024
Merged
Changes from 5 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
185dd04
chore(deps): add eslint-plugin-vuejs-accessibility [KHCP-11024]
portikM a31eba7
fix(*): fixable eslint-plugin-vuejs-accessibility issues [KHCP-11024]
portikM 56739d8
fix: resolve conflicts
portikM 2772098
chore(eslint): remove eslint-plugin-vuejs-accessibility [KHCP-11024]
portikM b50a5e1
chore: update lockfile
portikM cf2b9a1
fix(kcollapse): button type attribute [KHCP-11024]
portikM 597bb4b
fix(kmultiselect): remove listitem role [KHCP-11024]
portikM 3527068
fix(kselectitem, kmultiselectitem): role attributes [KHCP-11024]
portikM 845abe4
test(kselect): fix component tests [KHCP-11024]
portikM File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -3,9 +3,9 @@ | |
:key="item.key" | ||
class="select-item" | ||
:data-testid="`select-item-${item.value}`" | ||
@click="handleClick" | ||
> | ||
<div | ||
:aria-selected="item.selected" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. question: should this go on the parent? |
||
class="select-item-container" | ||
role="option" | ||
> | ||
|
@@ -14,6 +14,7 @@ | |
:disabled="item.disabled === true ? true : undefined" | ||
type="button" | ||
:value="item.value" | ||
@click="handleClick" | ||
adamdehaven marked this conversation as resolved.
Show resolved
Hide resolved
|
||
> | ||
<span class="select-item-label"> | ||
<slot name="content">{{ item.label }}</slot> | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
question: should this go on the parent?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, it belongs on the
role="option"
element. Same in KSelectItem