fix(ktable): remove next page clicked logic [KHCP-13030] #2352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for kongponents-sandbox ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for kongponents ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
portikM
changed the title
2eha0
reviewed
Aug 23, 2024
| // this will ensure buttons display the correct state for cases like search | ||
| if (!nextPageClicked.value) { | ||
| page.value = 1 | ||
| } | ||
| } else { | ||
| offset.value = res.pagination.offset |
There was a problem hiding this comment.
I don’t quite understand why we updated the offset here and then fixed it in the fetcher. Wouldn’t it make more sense to save res.pagination.offset into a variable like nextPageOffset and update the offset only when moving to the next page?
There was a problem hiding this comment.
I don't have permission to push a branch, I modified it locally and verified that it seems to work
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Addresses: https://konghq.atlassian.net/browse/KHCP-13030
Fixes bug when KTable sets page to 1 unexpectedly