Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ktable, ktableview): resizeColumns should ignore right clicks #2375

Merged
merged 1 commit into from
Sep 6, 2024

Conversation

Justineo
Copy link
Contributor

@Justineo Justineo commented Sep 6, 2024

Summary

The column resizer should ignore right clicks.

Before:

Sep-06-2024 17-46-49

After:

Sep-06-2024 17-48-23

@Justineo Justineo requested a review from a team as a code owner September 6, 2024 09:50
@CLAassistant
Copy link

CLAassistant commented Sep 6, 2024

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link

netlify bot commented Sep 6, 2024

Deploy Preview for kongponents-sandbox ready!

Name Link
🔨 Latest commit 2df3533
🔍 Latest deploy log https://app.netlify.com/sites/kongponents-sandbox/deploys/66dad050d137f50008b8a3b1
😎 Deploy Preview https://deploy-preview-2375--kongponents-sandbox.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Sep 6, 2024

Deploy Preview for kongponents ready!

Name Link
🔨 Latest commit 2df3533
🔍 Latest deploy log https://app.netlify.com/sites/kongponents/deploys/66dad0509253c50008891553
😎 Deploy Preview https://deploy-preview-2375--kongponents.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@adamdehaven adamdehaven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Justineo Justineo merged commit 4a0e2f6 into main Sep 6, 2024
9 checks passed
@Justineo Justineo deleted the fix/resize-columns-right-click branch September 6, 2024 14:14
kongponents-bot pushed a commit that referenced this pull request Sep 6, 2024
## [9.5.5](v9.5.4...v9.5.5) (2024-09-06)

### Bug Fixes

* **ktable, ktableview:** `resizeColumns` should ignore right clicks ([#2375](#2375)) ([4a0e2f6](4a0e2f6))
@kongponents-bot
Copy link
Collaborator

🎉 This PR is included in version 9.5.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants