-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ktable): fix row click handling [beta] #615
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for kongponents ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
adamdehaven
approved these changes
May 4, 2022
kongponents-bot
pushed a commit
that referenced
this pull request
May 4, 2022
# [7.0.0-beta.24](v7.0.0-beta.23...v7.0.0-beta.24) (2022-05-04) ### Bug Fixes * **ktable:** fix row click handling ([#615](#615)) ([ea47300](ea47300))
🎉 This PR is included in version 7.0.0-beta.24 🎉 The release is available on: Your semantic-release bot 📦🚀 |
kongponents-bot
pushed a commit
that referenced
this pull request
Aug 30, 2022
# [8.0.0-beta.1](v7.0.1...v8.0.0-beta.1) (2022-08-30) ### Bug Fixes * add comment ([c6d4784](c6d4784)) * backport [#763](#763) ([#765](#765)) ([6a18ce7](6a18ce7)) * backport fixes to beta ([#646](#646)) ([44479cc](44479cc)) * bump version ([bf50910](bf50910)) * **changelog:** update changelog ([0bc3f63](0bc3f63)) * **ci:** add type checks ([66898fe](66898fe)) * **colors:** update hex for steel-500 ([a88d185](a88d185)) * **css-variables:** move to separate mixin ([#626](#626)) ([7a1b0c9](7a1b0c9)) * **deps:** upgrade beta dependencies ([#687](#687)) ([3b78f01](3b78f01)) * doc fixes ([#593](#593)) ([23b38fc](23b38fc)) * **docs:** code snippet syntax ([#701](#701)) ([150c3d8](150c3d8)) * **docs:** remove component ([2503e6d](2503e6d)) * **eslint:** fix eslint config ([060b27b](060b27b)) * **eslint:** fix eslint config ([750d25c](750d25c)) * **favicon:** update favicon ([f465ab8](f465ab8)) * fix tests and add kalert ([59e6b79](59e6b79)) * fix tsconfig and upgrade deps ([1fc1365](1fc1365)) * font weights ([23e9f88](23e9f88)) * **font-weight:** fix font weights ([bac5214](bac5214)) * **kalert:** fix ellipse border radius ([d038f36](d038f36)) * **kalert:** fix kalert styles ([d69d0b4](d69d0b4)) * **kalert:** update default colors ([118320c](118320c)) * **kalert:** update default line-height ([047f5ac](047f5ac)) * **kalert:** word break in safari ([9bc80dd](9bc80dd)) * **kbadge:** add min width theming variable ([94aef53](94aef53)) * **kbadge:** adjust info colors ([#560](#560)) ([28a2819](28a2819)) * **kbadge:** doc issues [khcp-3409] ([#588](#588)) ([55f87d5](55f87d5)) * **kbreadcrumbs:** fix icon viewbox ([83cbd75](83cbd75)) * **kbreadcrumbs:** fix kicon prop ([0df2f69](0df2f69)) * **kbreadcrumbs:** icon size ([f7ce945](f7ce945)) * **kbutton,kicon:** fix button icon color [beta] ([#627](#627)) ([33a59b6](33a59b6)) * **kbutton:** add important to button disabled styles ([ddddf3c](ddddf3c)) * **kbutton:** button danger hover color ([741589b](741589b)) * **kbutton:** cannot spread attrs ([29c910b](29c910b)) * **kbutton:** disallow pointer-events for disabled button icon ([dcc6712](dcc6712)) * **kbutton:** falsy disabled attribute on native link element ([#690](#690)) ([2391fd5](2391fd5)) * **kbutton:** kong-icon within button should be inline-flex ([a1a3817](a1a3817)) * **kbutton:** remove opacity for disabled state ([1ecde38](1ecde38)) * **kbutton:** remove webkit tap highlight color ([efb0db3](efb0db3)) * **kbutton:** update disabled logic ([a8589c7](a8589c7)) * **kbutton:** update disabled logic ([ae34cb0](ae34cb0)) * **kbutton:** update disabled logic ([4f22383](4f22383)) * **kcard:** add padding top 0 to title ([6c159e6](6c159e6)) * **kcard:** port changes ([be00d83](be00d83)) * **kcard:** title positioning ([#562](#562)) ([9b56e3b](9b56e3b)) * **kcatalog,ktables:** docs and classes ([#621](#621)) ([5282363](5282363)) * **kcheckbox:** readonly styles ([#704](#704)) ([9ea5111](9ea5111)) * **kcheckbox:** update docs example ([3cd65b8](3cd65b8)) * **kemptystate:** backport [#720](#720) [beta] ([#721](#721)) ([1161571](1161571)) * **kicon:** fix var reference ([158031f](158031f)) * **kicon:** not updating reactively ([8cbaf8e](8cbaf8e)) * **kicon:** properly check for slot content ([#595](#595)) ([1d155e5](1d155e5)) * **kicon:** remove help icon unneeded path ([e85e24e](e85e24e)) * **kicon:** type errors ([5897b7c](5897b7c)) * **kicon:** update spinner stroke width ([4230808](4230808)) * **kicon:** update svg if icon props change ([#636](#636)) ([2db921e](2db921e)) * **kicon:** update vitals icon [beta] ([#732](#732)) ([a53ed6d](a53ed6d)) * **kinlineedit:** hover bg color [beta] ([02e17b1](02e17b1)) * **kinput:** add character limit event to docs ([f6413a9](f6413a9)) * **kinput:** deepclone value prop [beta] ([#651](#651)) ([4609bac](4609bac)) * **kinput:** update x icon for search input ([#643](#643)) ([b8db448](b8db448)) * **klabel:** default font weight to 600 ([f23282d](f23282d)) * **kmenu:** add comment ([92dbbc7](92dbbc7)) * **kmenu:** add comment ([91ad9d3](91ad9d3)) * **kmenu:** add comment ([9ee0ab2](9ee0ab2)) * **kmenu:** docs width prop [khcp-3409] ([#587](#587)) ([9ca2ad2](9ca2ad2)) * **kmenu:** properly extend type ([38b87ee](38b87ee)) * **kmenu:** type interface ([#578](#578)) ([01d3e10](01d3e10)) * **kmenu:** update type comment ([#579](#579)) ([3a050ea](3a050ea)) * **kmodal:** allow clicking on elements within the modal body [KHCP-4212] ([#709](#709)) ([c69c139](c69c139)) * **kmodal:** background color update ([4d15e91](4d15e91)) * **kmodal:** dismiss icon logic [beta] ([#738](#738)) ([f675223](f675223)) * **kmodal:** fix overflow to apply on mounted ([e4b7aae](e4b7aae)) * **kmodalfs:** backport spacing ([#683](#683)) ([de67137](de67137)) * **kmodalfullscreen:** align header [beta] ([bcf4ae9](bcf4ae9)) * **kmodalfullscreen:** align header [beta] ([#670](#670)) ([008c9ea](008c9ea)) * **kmodal:** hide body overflow ([d76d5b3](d76d5b3)) * **komponent:** remove komponent tag render ([b3147a5](b3147a5)) * **komponent:** rename komponent kcomponent ([43e777d](43e777d)) * **kooltip:** z-index bump ([#726](#726)) ([9fef3d5](9fef3d5)) * **kpagination:** style updates ([#581](#581)) ([5b2f54d](5b2f54d)) * **kpagination:** theming [KHCP-3431] ([#599](#599)) ([b9adcde](b9adcde)) * **kpagination:** use positionFixed [beta] ([#744](#744)) ([1a1952c](1a1952c)) * **kpop:** only one pop open at a time ([74cd66f](74cd66f)) * **kpopover:** fix logic to prevent errors [beta] ([#715](#715)) ([6b06b92](6b06b92)) * **kpop:** update target default ([#730](#730)) ([0492b37](0492b37)) * **kprompt:** adjust input margin ([925e577](925e577)) * **kprompt:** bottom divider ([#616](#616)) ([829a692](829a692)) * **kprompt:** docs fixes [khcp-3438] ([#591](#591)) ([7ed8aaa](7ed8aaa)) * **ksegmentedcontrol:** disabled logic [khcp-3433] ([#589](#589)) ([997508b](997508b)) * **kselect:** backport [#712](#712) [beta] ([#713](#713)) ([f39c7da](f39c7da)) * **kselect:** backport [#723](#723) ([#764](#764)) ([7ca14ac](7ca14ac)) * **kselect:** check attribute type ([ace3979](ace3979)) * **kselect:** disabled and readonly states [beta] ([#707](#707)) ([ff4c402](ff4c402)) * **kselect:** fix item margin bottom ([45f2671](45f2671)) * **kselect:** fix item margin bottom ([627fb17](627fb17)) * **kselect:** fix item structure ([b4b0bd8](b4b0bd8)) * **kselect:** input border radius and dropdown spacing [beta] ([#700](#700)) ([baa6738](baa6738)), closes [#694](#694) * **kselect:** kpop width ([f1afdd0](f1afdd0)) * **kselect:** page jump, caret, and docs ([#597](#597)) ([4110bcc](4110bcc)) * **kselect:** remove is-open prop on KInput ([#727](#727)) ([811303a](811303a)) * **kselect:** remove list style ([9755d4f](9755d4f)) * **kselect:** select popover pos ([#601](#601)) ([a117713](a117713)) * **kselect:** update items and filter logic ([#751](#751)) ([d6fc78b](d6fc78b)) * **kselect:** update popover width when it opens ([#735](#735)) ([9a979df](9a979df)) * **kskeleton:** delay-milliseconds default to 0 ([7ffa180](7ffa180)) * **kskeleton:** docs cleanup ([#602](#602)) ([b400be0](b400be0)) * **ktable,kcatalog:** backport [#685](#685) [beta] ([#686](#686)) ([90fe89b](90fe89b)) * **ktable,kcatalog:** data-testid additions ([#605](#605)) ([6ea25ed](6ea25ed)), closes [#603](#603) * **ktable,kcatalog:** fix issues ([#607](#607)) ([950c058](950c058)) * **ktable:** emit event on cell and row click [beta] ([#641](#641)) ([ab71839](ab71839)) * **ktable:** fix fetcher ([342f924](342f924)) * **ktable:** fix row click handling ([#615](#615)) ([ea47300](ea47300)) * **ktable:** hover color fix ([209e4fa](209e4fa)) * **ktable:** more row click fix [beta] ([#619](#619)) ([0c54110](0c54110)) * **ktable:** remove unneeded prop ([7660abe](7660abe)) * **ktable:** row click slotted content ([#610](#610)) ([0c550b8](0c550b8)) * **ktable:** update v-on value ([#746](#746)) ([5aa2f50](5aa2f50)) * **ktextarea:** docs cleanup ([#600](#600)) ([8cc36fb](8cc36fb)) * misc cleanup ([#757](#757)) ([47f072b](47f072b)) * **publish:** fix typings ([71d9b8e](71d9b8e)) * readme ([68eae7a](68eae7a)) * **release:** trigger release ([d21a824](d21a824)) * remove comment ([8d0036f](8d0036f)) * remove unneeded scripts ([bc5e637](bc5e637)) * **sass:** restructure files ([1d27287](1d27287)) * **styles:** alter some styles for dark mode ([d7b8114](d7b8114)) * **styles:** fix input error css ([215ebcc](215ebcc)) * **styles:** fix styles ([33e0258](33e0258)) * **tables:** fix docs table code style ([8c3c0ee](8c3c0ee)) * **tables:** fix table styles ([4d4136d](4d4136d)) * **theming:** disable theming page components ([33a91f9](33a91f9)) * **truncate-multi:** fix pixel multiplication ([#624](#624)) ([0b08062](0b08062)) * **types:** fix type imports ([549f1d4](549f1d4)) * **typography:** docs display ([#604](#604)) ([d0bca1f](d0bca1f)) * **typography:** text display [khcp-3407] ([#590](#590)) ([36c3a35](36c3a35)) * update dependencies and code for new beta version ([#656](#656)) ([2609629](2609629)) * update icon md file ([#742](#742)) ([15f6a80](15f6a80)) * **uuid:** replaced vue-uuid with uuid ([62a14fd](62a14fd)) * **variables:** rename mixin ([544c762](544c762)) * **version:** bump release version ([187639b](187639b)) * vuepress indentation ([5f1b05b](5f1b05b)) ### Features * **fonts:** default to non-licensed font-family ([#611](#611)) ([0a41821](0a41821)) * **kbadge:** add kbadge ([ece2198](ece2198)) * **kbreadcrumbs:** adding kbreadcrumbs ([a2dae4e](a2dae4e)) * **kbutton:** update kbutton with icon prop ([#544](#544)) ([16b0915](16b0915)) * **kcard:** add kcard ([7d045fd](7d045fd)) * **kcatalog:** vue3 upgrade ([#584](#584)) ([e76362e](e76362e)) * **kcheckbox:** update for vue 3 ([#550](#550)) ([5275647](5275647)) * **kclipboardprovider:** add clipboard provider ([d35c5d1](d35c5d1)) * **kdropdownmenu:** new kongponent [beta] ([#740](#740)) ([5868209](5868209)) * **kemptystate:** add kemptystate ([#531](#531)) ([97ff949](97ff949)) * **kicon:** add arrow up/down icons ([#739](#739)) ([7b2e6f7](7b2e6f7)) * **kicon:** add book, plug and contactSupport icons ([#761](#761)) ([986f5d4](986f5d4)), closes [#760](#760) * **kicon:** add increase/decrease icons [ma-643] ([#655](#655)) ([a3beae6](a3beae6)), closes [#654](#654) * **kicon:** horizontal dots ([#582](#582)) ([a60ae2f](a60ae2f)) * **kinlineedit:** upgrade for vue 3 ([#551](#551)) ([3cbf87d](3cbf87d)) * **kinput:** add characterLimit ([#630](#630)) ([18ae326](18ae326)) * **kinput:** add kinput ([191d1b6](191d1b6)) * **kinput:** add kinput enhancements to vue 3 version ([#528](#528)) ([96c5a30](96c5a30)) * **kinputswitch:** update kinputswitch for vue 3 ([#569](#569)) ([9b55021](9b55021)) * **kmenu:** update kmenu for vue 3 ([#573](#573)) ([dbdfa7c](dbdfa7c)) * **kmodal:** adding kmodal ([e003563](e003563)) * **kmodalfullscreen:** vue 3 upgrade ([#585](#585)) ([a63121e](a63121e)) * **kmodal:** updates for quickstart [beta] ([#711](#711)) ([705faec](705faec)) * **kpagination/ktable:** support offset-based pagination ([#665](#665)) ([e594cbc](e594cbc)) * **kpagination:** upgrade kpagination to vue 3 [KHCP-2750] ([#534](#534)) ([6b3c653](6b3c653)) * **kpop:** adding kpop ([9a58200](9a58200)) * **kprompt:** update kprompt for vue 3 ([#568](#568)) ([5d30c52](5d30c52)) * **kradio:** update for vue 3 ([#552](#552)) ([9c2bdde](9c2bdde)) * **ksegmentedcontrol:** update ksegmentedcontrol for vue 3 ([#572](#572)) ([8c73618](8c73618)) * **kselect:** add autosuggest support [KHCP-4292] ([#722](#722)) ([92156c0](92156c0)) * **kselect:** add clearable prop ([#762](#762)) ([8a572df](8a572df)), closes [#749](#749) * **kselect:** add overlayLabel support [beta] ([#694](#694)) ([2d6060d](2d6060d)) * **kselect:** filterfunc support ([#598](#598)) ([c69de57](c69de57)) * **kselect:** misc fixes [beta] ([#691](#691)) ([a3815ed](a3815ed)) * **kselect:** upgrade kselect for vue 3 ([#535](#535)) ([84a0e16](84a0e16)) * **kskeleton:** update kskeleton for vue 3 [KHCP-2755] ([#538](#538)) ([d1dcbe3](d1dcbe3)) * **kslideout:** update kslideout for vue 3 ([#571](#571)) ([4c69227](4c69227)) * **kstepper:** new kongponent [beta] ([#755](#755)) ([8ff7742](8ff7742)) * **kstyles:** multi-line truncation [beta] ([#653](#653)) ([79c53e0](79c53e0)) * **ktable:** add sortHandlerFn ([#580](#580)) ([ebc7202](ebc7202)) * **ktable:** support for conditional events [beta] ([#637](#637)) ([e77f02f](e77f02f)) * **ktable:** update ktable for vue 3 [KHCP-2757] ([#536](#536)) ([3d873d6](3d873d6)) * **ktabs:** update ktabs for vue 3 ([#570](#570)) ([900d71c](900d71c)) * **ktextarea:** upgrade to vue 3 ([#549](#549)) ([0e53d4f](0e53d4f)) * **ktoaster:** add ktoaster ([6a24e4d](6a24e4d)) * **ktoaster:** add tests and docs ([ee337be](ee337be)) * **ktoggle:** adding ktoggle ([c202736](c202736)) * **ktooltip:** adding ktooltip ([e169b82](e169b82)) * **kviewswitcher:** update k-view-switcher for vue 3 ([#557](#557)) ([5c5909c](5c5909c)) * publish beta release [KHCP-3330] ([7c964fe](7c964fe)) * publish v7-beta [KHCP-3330] ([27b3bcf](27b3bcf)) * testing semantic release ([f254c4b](f254c4b)) ### Reverts * commit bcf4ae9 ([8cc34d3](8cc34d3)) * revert beta release ([d1851e5](d1851e5)) ### BREAKING CHANGES * Update Kongponents to v7.0.0-beta.* for usage with Vue 3. If your project still uses Vue 2, use the @kongponents/* packages instead. * Update Kongponents to v7 for usage with Vue v3. If your project uses Vue 2, you should check out the @kongponents/* packages.
🎉 This PR is included in version 8.0.0-beta.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix handling of row click events.
Changes made:
a
,button
, andinput
Vue 3 Upgrade
If your PR contains code that needs to be ported to the
beta
branch, please add theport to beta branch
label to your PR.If you have questions, tag
@adamdehaven
or@kaiarrowood
.PR Checklist