Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(kselect): fix items watcher and only update if changed [KHCP-4425] #750

Merged
merged 2 commits into from
Aug 9, 2022

Conversation

adamdehaven
Copy link
Member

@adamdehaven adamdehaven commented Aug 9, 2022

Summary

  • Only trigger the items watcher if the items changed
  • Ensure every item always has a selected property (boolean)
  • Prevent the item.key from having extra -selected text appended if already selected

Vue 3

Did you create a corresponding PR to add this change to the beta branch? (required)

If you have questions, tag @adamdehaven or @kaiarrowood.


PR Checklist

  • Does not introduce dependencies
  • Functional: all changes do not break existing APIs and if so, bump major version.
  • Tests pass: check the output of yarn test packages/
  • Naming: the files and the method and prop variables use the same naming conventions as other Kongponents
  • Framework style: abides by the essential rules in Vue's style guide
  • Cleanliness: does not have formatting issues, unused code (e.g., console.logs), or leftover comments
  • Docs: includes a technically accurate README, uses JSDOC where appropriate

@netlify
Copy link

netlify bot commented Aug 9, 2022

Deploy Preview for kongponents ready!

Name Link
🔨 Latest commit 4f83f83
🔍 Latest deploy log https://app.netlify.com/sites/kongponents/deploys/62f28ea0157e39000861c444
😎 Deploy Preview https://deploy-preview-750--kongponents.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@adamdehaven adamdehaven merged commit a80958b into main Aug 9, 2022
@adamdehaven adamdehaven deleted the fix/khcp-4425-kselect-first-click branch August 9, 2022 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant