Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(modal): not importing icon component #806

Merged
merged 1 commit into from
Sep 23, 2022
Merged

fix(modal): not importing icon component #806

merged 1 commit into from
Sep 23, 2022

Conversation

kleinfreund
Copy link
Contributor

Summary

Fixes an issue with the modal component not importing the KIcon component that it uses.

Signed-off-by: Philipp Rudloff philipp.rudloff@konghq.com

PR Checklist

  • Does not introduce dependencies
  • Functional: all changes do not break existing APIs and if so, bump major version.
  • Tests pass: check the output of yarn test packages/
  • Naming: the files and the method and prop variables use the same naming conventions as other Kongponents
  • Framework style: abides by the essential rules in Vue's style guide
  • Cleanliness: does not have formatting issues, unused code (e.g., console.logs), or leftover comments
  • Docs: includes a technically accurate README, uses JSDOC where appropriate

fix(modal): not importing icon component
fcf10df 
Fixes an issue with the modal component not importing the `KIcon` component that it uses.

Signed-off-by: Philipp Rudloff <philipp.rudloff@konghq.com>
@netlify
Copy link

netlify bot commented Sep 23, 2022

✅ Deploy Preview for kongponents ready!

Name Link
🔨 Latest commit fcf10df
🔍 Latest deploy log https://app.netlify.com/sites/kongponents/deploys/632d7ee5fabafc0008464489
😎 Deploy Preview https://deploy-preview-806--kongponents.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@kleinfreund kleinfreund marked this pull request as ready for review September 23, 2022 09:56
kaiarrowood
kaiarrowood approved these changes Sep 23, 2022
View reviewed changes
Copy link
Collaborator

@kaiarrowood kaiarrowood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kaiarrowood kaiarrowood merged commit 92f20e6 into Kong:beta Sep 23, 2022
@kaiarrowood kaiarrowood mentioned this pull request Sep 23, 2022
Merged
10 tasks
kongponents-bot pushed a commit that referenced this pull request Sep 23, 2022
@semantic-release-bot
chore(release): 8.0.0-beta.19 [skip ci]
7691d6f 
# [8.0.0-beta.19](v8.0.0-beta.18...v8.0.0-beta.19) (2022-09-23)

### Bug Fixes

* **ktable:** doc revalidate usage [khcp-4670] ([#805](#805)) ([e1b6f7e](e1b6f7e))
* **modal:** not importing icon component ([#806](#806)) ([92f20e6](92f20e6))
@kongponents-bot
Copy link
Collaborator

🎉 This PR is included in version 8.0.0-beta.19 🎉

The release is available on:

Your semantic-release bot 📦🚀

@kleinfreund kleinfreund deleted the fix/modal-not-importing-icon branch September 23, 2022 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaiarrowood kaiarrowood kaiarrowood approved these changes

@adamdehaven adamdehaven Awaiting requested review from adamdehaven

@aanchalm01 aanchalm01 Awaiting requested review from aanchalm01

@jillztom jillztom Awaiting requested review from jillztom

Assignees
No one assigned
Labels
released on @beta
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kleinfreund @kongponents-bot @kaiarrowood