feat: add KongPluginBinding scope #236
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
czeslavo
force-pushed
the
feat/global-plugins
branch
from
36e3481 to
36b8e56
Compare
czeslavo
force-pushed
the
feat/global-plugins
branch
2 times, most recently
from
7f6b579 to
186e402
Compare
czeslavo
force-pushed
the
feat/global-plugins
branch
from
186e402 to
fe0e5b1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Adds a
scopefield to theKongPluginBindingSpecwith a default value ofOnlyTargetsthat preserves the previous default behavior (applying a plugin to targets). Also addsGlobalInControlPlaneenum value that allows configuring a plugin to be applied globally to a control plane.Which issue this PR fixes
Closes #7. Part of Kong/gateway-operator#440.
PR Readiness Checklist:
Complete these before marking the PR as
ready to review:CHANGELOG.mdrelease notes have been updated to reflect significant changes