fix: remove finalizer handling

Originally we added finalizers with the intention of holding back object deletion until we were certain that we had removed the relevant configuration from the Kong Admin API. Ultimately at the time of writing it's not feasible to get this done, so this removes a half of the implementation which was causing us complexity without any added value.
Kong · Jul 10, 2021 · 1553b0f · 1553b0f
1 parent 1eaeda3
commit 1553b0f
Show file tree

Hide file tree

Showing 5 changed files with 8 additions and 332 deletions.
diff --git a/railgun/config/rbac/role.yaml b/railgun/config/rbac/role.yaml
@@ -13,12 +13,6 @@ rules:
   verbs:
   - list
   - watch
-- apiGroups:
-  - ""
-  resources:
-  - endpoints/finalizers
-  verbs:
-  - update
 - apiGroups:
   - ""
   resources:
@@ -56,12 +50,6 @@ rules:
   verbs:
   - list
   - watch
-- apiGroups:
-  - ""
-  resources:
-  - secrets/finalizers
-  verbs:
-  - update
 - apiGroups:
   - ""
   resources:
@@ -78,12 +66,6 @@ rules:
   - get
   - list
   - watch
-- apiGroups:
-  - ""
-  resources:
-  - services/finalizers
-  verbs:
-  - update
 - apiGroups:
   - ""
   resources:
@@ -100,12 +82,6 @@ rules:
   - get
   - list
   - watch
-- apiGroups:
-  - apiextensions.k8s.io
-  resources:
-  - ingresses/finalizers
-  verbs:
-  - update
 - apiGroups:
   - apiextensions.k8s.io
   resources:
@@ -122,12 +98,6 @@ rules:
   - get
   - list
   - watch
-- apiGroups:
-  - configuration.konghq.com
-  resources:
-  - kongclusterplugins/finalizers
-  verbs:
-  - update
 - apiGroups:
   - configuration.konghq.com
   resources:
@@ -144,12 +114,6 @@ rules:
   - get
   - list
   - watch
-- apiGroups:
-  - configuration.konghq.com
-  resources:
-  - kongconsumers/finalizers
-  verbs:
-  - update
 - apiGroups:
   - configuration.konghq.com
   resources:
@@ -166,12 +130,6 @@ rules:
   - get
   - list
   - watch
-- apiGroups:
-  - configuration.konghq.com
-  resources:
-  - kongingresses/finalizers
-  verbs:
-  - update
 - apiGroups:
   - configuration.konghq.com
   resources:
@@ -188,12 +146,6 @@ rules:
   - get
   - list
   - watch
-- apiGroups:
-  - configuration.konghq.com
-  resources:
-  - kongplugins/finalizers
-  verbs:
-  - update
 - apiGroups:
   - configuration.konghq.com
   resources:
@@ -210,12 +162,6 @@ rules:
   - get
   - list
   - watch
-- apiGroups:
-  - configuration.konghq.com
-  resources:
-  - tcpingresses/finalizers
-  verbs:
-  - update
 - apiGroups:
   - configuration.konghq.com
   resources:
@@ -232,12 +178,6 @@ rules:
   - get
   - list
   - watch
-- apiGroups:
-  - configuration.konghq.com
-  resources:
-  - udpingresses/finalizers
-  verbs:
-  - update
 - apiGroups:
   - configuration.konghq.com
   resources:
@@ -254,12 +194,6 @@ rules:
   - get
   - list
   - watch
-- apiGroups:
-  - networking.internal.knative.dev
-  resources:
-  - ingresses/finalizers
-  verbs:
-  - update
 - apiGroups:
   - networking.internal.knative.dev
   resources:
@@ -276,12 +210,6 @@ rules:
   - get
   - list
   - watch
-- apiGroups:
-  - networking.k8s.io
-  resources:
-  - ingresses/finalizers
-  verbs:
-  - update
 - apiGroups:
   - networking.k8s.io
   resources:
@@ -306,12 +234,6 @@ rules:
   verbs:
   - list
   - watch
-- apiGroups:
-  - ""
-  resources:
-  - endpoints/finalizers
-  verbs:
-  - update
 - apiGroups:
   - ""
   resources:
@@ -349,12 +271,6 @@ rules:
   verbs:
   - list
   - watch
-- apiGroups:
-  - ""
-  resources:
-  - secrets/finalizers
-  verbs:
-  - update
 - apiGroups:
   - ""
   resources:
@@ -371,12 +287,6 @@ rules:
   - get
   - list
   - watch
-- apiGroups:
-  - ""
-  resources:
-  - services/finalizers
-  verbs:
-  - update
 - apiGroups:
   - ""
   resources:
@@ -393,12 +303,6 @@ rules:
   - get
   - list
   - watch
-- apiGroups:
-  - apiextensions.k8s.io
-  resources:
-  - ingresses/finalizers
-  verbs:
-  - update
 - apiGroups:
   - apiextensions.k8s.io
   resources:
@@ -415,12 +319,6 @@ rules:
   - get
   - list
   - watch
-- apiGroups:
-  - configuration.konghq.com
-  resources:
-  - kongclusterplugins/finalizers
-  verbs:
-  - update
 - apiGroups:
   - configuration.konghq.com
   resources:
@@ -437,12 +335,6 @@ rules:
   - get
   - list
   - watch
-- apiGroups:
-  - configuration.konghq.com
-  resources:
-  - kongconsumers/finalizers
-  verbs:
-  - update
 - apiGroups:
   - configuration.konghq.com
   resources:
@@ -459,12 +351,6 @@ rules:
   - get
   - list
   - watch
-- apiGroups:
-  - configuration.konghq.com
-  resources:
-  - kongingresses/finalizers
-  verbs:
-  - update
 - apiGroups:
   - configuration.konghq.com
   resources:
@@ -481,12 +367,6 @@ rules:
   - get
   - list
   - watch
-- apiGroups:
-  - configuration.konghq.com
-  resources:
-  - kongplugins/finalizers
-  verbs:
-  - update
 - apiGroups:
   - configuration.konghq.com
   resources:
@@ -503,12 +383,6 @@ rules:
   - get
   - list
   - watch
-- apiGroups:
-  - configuration.konghq.com
-  resources:
-  - tcpingresses/finalizers
-  verbs:
-  - update
 - apiGroups:
   - configuration.konghq.com
   resources:
@@ -525,12 +399,6 @@ rules:
   - get
   - list
   - watch
-- apiGroups:
-  - configuration.konghq.com
-  resources:
-  - udpingresses/finalizers
-  verbs:
-  - update
 - apiGroups:
   - configuration.konghq.com
   resources:
@@ -547,12 +415,6 @@ rules:
   - get
   - list
   - watch
-- apiGroups:
-  - networking.internal.knative.dev
-  resources:
-  - ingresses/finalizers
-  verbs:
-  - update
 - apiGroups:
   - networking.internal.knative.dev
   resources:
@@ -569,12 +431,6 @@ rules:
   - get
   - list
   - watch
-- apiGroups:
-  - networking.k8s.io
-  resources:
-  - ingresses/finalizers
-  verbs:
-  - update
 - apiGroups:
   - networking.k8s.io
   resources: