Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make all-in-one-dbless use SCD #3423

Closed
2 of 6 tasks
Tracked by #702
pmalek opened this issue Jan 23, 2023 · 5 comments · Fixed by #3629
Closed
2 of 6 tasks
Tracked by #702

Make all-in-one-dbless use SCD #3423

pmalek opened this issue Jan 23, 2023 · 5 comments · Fixed by #3629
Assignees
Milestone

Comments

@pmalek
Copy link
Member

pmalek commented Jan 23, 2023

Is there an existing issue for this?

  • I have searched the existing issues

Problem Statement

After #702 gets implemented in the controller we have to expose this functionality to the end users.

This issue aims to track this effort.

Proposed Solution

  • Change all the all-in-one DBLESS manifests to use SCD.
  • Mark the old all-in-one-dbless.yaml as deprecated by renaming it to all-in-one-dbless-legacy.yaml

Additional information

No response

Acceptance Criteria

  • As a user I can deploy KIC with Gateway using "all-in-one" manifest(s) and leverage Support single controller deployments #702.
  • The old all-in-one-dbless.yaml (using a single Pod deployment) is renamed to all-in-one-dbless-legacy.yaml
  • All all-in-one DBLESS manifests in deploy/single use SCD and their paths are unchanged.
  • E2E tests using old all-in-one-dbless.yaml use the new one (with the same name, but using SCD)
  • There's an E2E verifying all-in-one-dbless-legacy.yaml works as expected
@pmalek
Copy link
Member Author

pmalek commented Feb 9, 2023

This is almost done.

Users can already use deploy/single/all-in-one-dbless-multi-gw.yaml to install KIC in SCD mode (separate KIC and Gateway deployments).

Currently those manifests use 2.8.1 tag for KIC, hence its deployment is expected to fail with this until 2.9 is released (with #3421) and used in those manifests.

@mflendrich mflendrich changed the title Single controller deployments: support in manifests Make all-in-one-dbless use SCD Feb 17, 2023
@czeslavo
Copy link
Contributor

Do the ACs still hold?

  1. All all-in-one DBLESS manifests in deploy/single use SCD and their paths are unchanged.

Do we really intend to deprecate the old DB-less single-pod setup and replace it with gw-discovery?

We've introduced deploy/single/all-in-one-dbless-multi-gw.yaml which became a separate, brand-new deploy option.

I'd say it should still be a valid config to have a single Pod deployment as it's the simplest one which in many cases will be sufficient for users. Please correct me if I'm wrong.

@pmalek
Copy link
Member Author

pmalek commented Feb 27, 2023

I'm not sure I recall correctly what was the consensus on our sync meeting for this matter.

I believe this is blocked on a internally tracked action item to figure out the supported set of topologies in all-in-one manifests, right? cc: @mflendrich

@czeslavo
Copy link
Contributor

After our discussion on Slack, I have updated the ACs of this issue to be more precise in terms of renaming the all-in-one manifests and covering E2E tests adaptation. @pmalek @mflendrich please take a look if that makes sense.

@pmalek
Copy link
Member Author

pmalek commented Feb 28, 2023

After our discussion on Slack, I have updated the ACs of this issue to be more precise in terms of renaming the all-in-one manifests and covering E2E tests adaptation. @pmalek @mflendrich please take a look if that makes sense.

👍 from me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants