Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(scd): add multi-gw manifests variant #3483

Merged
merged 1 commit into from
Feb 3, 2023

Conversation

czeslavo
Copy link
Contributor

@czeslavo czeslavo commented Feb 3, 2023

What this PR does / why we need it:

Moves multi-gw manifests under config/variants and allows building a single deployment file out of them to be used not in debug mode (can become useful to test this configuration in E2E tests).

Which issue this PR fixes:

Fixes #3480.

@czeslavo czeslavo changed the title chore(sdc): add multi-gw manifests variant chore(scd): add multi-gw manifests variant Feb 3, 2023
@czeslavo czeslavo force-pushed the multiple-gw-config-variant branch from 5556dec to 2189330 Compare February 3, 2023 17:22
@codecov
Copy link

codecov bot commented Feb 3, 2023

Codecov Report

Base: 73.8% // Head: 74.0% // Increases project coverage by +0.1% 🎉

Coverage data is based on head (2189330) compared to base (f1793b7).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##            main   #3483     +/-   ##
=======================================
+ Coverage   73.8%   74.0%   +0.1%     
=======================================
  Files        118     118             
  Lines      13990   13990             
=======================================
+ Hits       10333   10356     +23     
+ Misses      2993    2976     -17     
+ Partials     664     658      -6     
Impacted Files Coverage Δ
internal/dataplane/kongstate/service.go 66.0% <0.0%> (-1.3%) ⬇️
internal/dataplane/parser/parser.go 90.7% <0.0%> (+0.6%) ⬆️
...ternal/controllers/gateway/httproute_controller.go 71.6% <0.0%> (+1.8%) ⬆️
...nternal/controllers/gateway/tlsroute_controller.go 73.4% <0.0%> (+2.0%) ⬆️
...nternal/controllers/gateway/udproute_controller.go 73.7% <0.0%> (+2.1%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@czeslavo czeslavo marked this pull request as ready for review February 3, 2023 17:54
@czeslavo czeslavo requested a review from a team as a code owner February 3, 2023 17:54
@czeslavo czeslavo self-assigned this Feb 3, 2023
@czeslavo czeslavo added the area/maintenance Cleanup, refactoring, and other maintenance improvements that don't change functionality. label Feb 3, 2023
@czeslavo czeslavo enabled auto-merge (squash) February 3, 2023 18:00
@czeslavo czeslavo merged commit 99768a5 into main Feb 3, 2023
@czeslavo czeslavo deleted the multiple-gw-config-variant branch February 3, 2023 18:53
@czeslavo
Copy link
Contributor Author

This was part of #3423.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/maintenance Cleanup, refactoring, and other maintenance improvements that don't change functionality. size/XXL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move multi gateway skaffold kustomize manifests under config/variants
2 participants