Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to KongIngress are not reflected in Kong until the Ingress is recreated #91

Closed
jaygorrell opened this issue Aug 15, 2018 · 2 comments
Assignees

Comments

@jaygorrell
Copy link
Contributor

Summary

Creating a KongIngress and Ingress resource correctly configures Kong but subsequent edits ot the KongIngress are not immediately reflected in Kong. Deleting and recreating the Ingress will force Kong to be updated.

This may apply to more than the KongIngress resource, but this is where I first noticed the problem.

kong:0.13.1-centos

Kubernetes version

1.9.3

What happened

Changes to the KongIngress resource (strip_path) were not reflected in the Kong configuration.

Expected behvaior

Changes to KongIngress are picked up and applied by Kong.

Steps To Reproduce

  1. Create the following (assuming a service myservice exists)
apiVersion: configuration.konghq.com/v1
kind: KongIngress
metadata:
  name: mykongingress
route:
  strip_path: true

---

apiVersion: extensions/v1beta1
kind: Ingress
metadata:
  name: myingress
  annotations:
    configuration.konghq.com: mykongingress
spec:
  rules:
  - host: foo.bar
    http:
      paths:
      - path: /foo
        backend:
          serviceName: myservice
          servicePort: 80
  1. Verify settings in Kong /routes
  2. Change strip_path to false and apply changes
  3. Observe that settings in Kong have not changed
  4. Delete/create myingress again
  5. Observe that settings in Kong have been updated
@hbagdi hbagdi self-assigned this Aug 15, 2018
hbagdi added a commit that referenced this issue Aug 15, 2018
When KongIngress object is updated, the properties of affected routes in
Kong were not changed (#91). This was a known issue and was left as a future
TODO in the past.

This change picks up the changes from KongIngress and patches the routes
in Kong as needed.
hbagdi added a commit that referenced this issue Aug 15, 2018
When `KongIngress` object is updated, the properties of affected routes in
Kong were not changed (#91). This was a known issue and was left as a future
TODO in the past.

This change picks up the changes from `KongIngress` and patches the routes
in Kong as needed.

From #92
@hbagdi
Copy link
Member

hbagdi commented Aug 15, 2018

Hello @jaygorrell,

Thank you for opening this bug. #92, now merged to master, fixes this problem.

@sbabutk
Copy link

sbabutk commented Feb 7, 2019

I experiencing the same issue, what version of ingress-controller have this fix?
I am using

  • kong-docker-kubernetes-ingress-controller:0.1.3
  • kong-enterprise-edition:0.34-1-alpine

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants