refactor: Move library packages from internal/ to pkg/ #1027
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the following packages:
internal/ingress/controller/parser/kongstate
->pkg/kongstate
internal/ingress/controller/parser
->pkg/parser
internal/ingress/controller/util
ANDinternal/ingress/utils
->pkg/util
(merged)internal/ingress/controller/store
->pkg/store
internal/ingress/annotations
->pkg/annotations
in order to allow for use of KIC's logic (that's not tightly coupled with the controller loop) as a library from an external source (specifically: in an experimental new implementation of the controller).
If the change looks good, it needs to be merged ASAP (and ported to
next
even ASAPer) because it will cause merge conflicts in all work in flight.Future work: decouple Kong updating logic from
type KongController
ininternal/ingress/controller
.