Sendconfig update improvements #1397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in my testing, DBLESS and Postgres mode have both shown problems with repetitive sub-second updates. This is something we're tracking as a potential bug elsewhere, but for now increasing the interval seems to make the most sense for stability, as testing has shown it reduces/removes the timing problems which we've encountered with subsecond interval updates.
Recent updates have made our controller faster and having such a long Ingress timeout doesn't make sense any longer: it just increasing the time it takes to reach a timeout condition on certain kinds of failures.
Codecov Report
@@ Coverage Diff @@
## next #1397 +/- ##
==========================================
- Coverage 55.20% 55.12% -0.08%
==========================================
Files 42 42
Lines 3639 3646 +7
==========================================
+ Hits 2009 2010 +1
- Misses 1479 1485 +6
Partials 151 151
Continue to review full report at Codecov.
|
shaneutt
force-pushed
the
calmer-sendconfig
branch
from
c60a87e to
81e76be
Compare
ccfishk
reviewed
Jun 4, 2021
ccfishk
reviewed
Jun 4, 2021
shaneutt
commented
Jun 4, 2021
|
The follow up issue for this PR (wherein we will further investigate after this mitigation) is: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In CI there have been several problems that appear to be due to the high rate at which KIC 2.0 has been sending updates to the Kong Admin API at a regular interval. This PR includes some improvements that seemed to function better with minimal/no end-user impact, while making the defaults less noisy in testing/CI. This also adds an update to
sendconfig.SendUpdate()which will stifle repetitivenilupdate warnings (you'll get one once for each update that would make no change now, rather than them repeating every few seconds).This helps to resolve #1390