Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --profiling to 2.x #1416

Closed
wants to merge 3 commits into from
Closed

Add --profiling to 2.x #1416

wants to merge 3 commits into from

Conversation

rainest
Copy link
Contributor

@rainest rainest commented Jun 10, 2021

Carry-over from #1408 that cherry-picks the relevant commits. Base changes made a mess of the original PR.

Signed-off-by: Tharun <rajendrantharun@live.com>
Signed-off-by: Tharun <rajendrantharun@live.com>
@rainest rainest requested a review from a team as a code owner June 10, 2021 21:26
@rainest rainest temporarily deployed to Configure ci June 10, 2021 21:27 Inactive
@rainest rainest changed the title Feat/rg profiling Add --profiling to 2.x Jun 10, 2021
@rainest rainest temporarily deployed to Configure ci June 10, 2021 21:28 Inactive
@codecov
Copy link

codecov bot commented Jun 10, 2021

Codecov Report

Merging #1416 (c35004b) into next (68c8259) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             next    #1416   +/-   ##
=======================================
  Coverage   55.37%   55.37%           
=======================================
  Files          42       42           
  Lines        3646     3646           
=======================================
  Hits         2019     2019           
  Misses       1477     1477           
  Partials      150      150           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 68c8259...c35004b. Read the comment docs.

@tharun208
Copy link
Contributor

tharun208 commented Jun 10, 2021

@rainest can you also add this commit - a953ba7 ?

and can i close the original pr ?

Signed-off-by: Tharun <rajendrantharun@live.com>
@rainest rainest temporarily deployed to Configure ci June 10, 2021 21:33 Inactive
@rainest rainest temporarily deployed to Configure ci June 10, 2021 21:33 Inactive
@tharun208
Copy link
Contributor

@rainest usually feature PR's get merged to next and then to main or another way around ?. If this is documented under CONTRIBUTING.md means helpful.

@rainest
Copy link
Contributor Author

rainest commented Jun 10, 2021

@tharun208 feature PRs go to next, yes. It's mentioned at the end of the https://github.com/Kong/kubernetes-ingress-controller/blob/main/CONTRIBUTING.md#finding-work section.

The only changes that go direct to main are repo metadata (CI changes and the like) and bugfixes that would be released in a patch release.

@tharun208 tharun208 mentioned this pull request Jun 11, 2021
1 task
@mflendrich
Copy link
Contributor

This PR is identical to #1417 and we'll need to merge just one of these (both PRs are retries of #1408)

Closing this one in favor of merging #1417 to ensure that the PR is properly attributed to @tharun208.

@mflendrich mflendrich closed this Jun 11, 2021
@shaneutt shaneutt deleted the feat/rg-profiling branch October 27, 2021 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants