-
Notifications
You must be signed in to change notification settings - Fork 593
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add --profiling to 2.x #1416
Add --profiling to 2.x #1416
Conversation
Signed-off-by: Tharun <rajendrantharun@live.com>
Signed-off-by: Tharun <rajendrantharun@live.com>
Codecov Report
@@ Coverage Diff @@
## next #1416 +/- ##
=======================================
Coverage 55.37% 55.37%
=======================================
Files 42 42
Lines 3646 3646
=======================================
Hits 2019 2019
Misses 1477 1477
Partials 150 150 Continue to review full report at Codecov.
|
Signed-off-by: Tharun <rajendrantharun@live.com>
@rainest usually feature PR's get merged to next and then to main or another way around ?. If this is documented under |
@tharun208 feature PRs go to next, yes. It's mentioned at the end of the https://github.com/Kong/kubernetes-ingress-controller/blob/main/CONTRIBUTING.md#finding-work section. The only changes that go direct to main are repo metadata (CI changes and the like) and bugfixes that would be released in a patch release. |
This PR is identical to #1417 and we'll need to merge just one of these (both PRs are retries of #1408) Closing this one in favor of merging #1417 to ensure that the PR is properly attributed to @tharun208. |
Carry-over from #1408 that cherry-picks the relevant commits. Base changes made a mess of the original PR.