Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[KEP] 0007-performance-test #1456

Closed
wants to merge 2 commits into from
Closed

[KEP] 0007-performance-test #1456

wants to merge 2 commits into from

Conversation

ccfishk
Copy link
Contributor

@ccfishk ccfishk commented Jun 23, 2021


status: provisional

Kubernetes Ingress Controller (KIC) Performance Testing

Summary

Motivation

Goals

Non Goals

Proposal

use KEPs under github GUI
@ccfishk ccfishk requested a review from a team as a code owner June 23, 2021 20:28
@codecov
Copy link

codecov bot commented Jun 23, 2021

Codecov Report

Merging #1456 (1d4188c) into main (e59a9fd) will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1456      +/-   ##
==========================================
+ Coverage   48.33%   48.36%   +0.03%     
==========================================
  Files          91       91              
  Lines        5783     5783              
==========================================
+ Hits         2795     2797       +2     
+ Misses       2739     2738       -1     
+ Partials      249      248       -1     
Flag Coverage Δ
integration-test 40.82% <ø> (+0.11%) ⬆️
unit-test 40.56% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...trollers/configuration/zz_generated_controllers.go 42.60% <0.00%> (+0.70%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e59a9fd...1d4188c. Read the comment docs.

@ccfishk ccfishk changed the title Create 0007-performance-test.md [KEP] 0007-performance-test Jun 23, 2021
@ccfishk ccfishk removed the request for review from a team June 23, 2021 20:54
@ccfishk ccfishk self-assigned this Jun 23, 2021
@ccfishk
Copy link
Contributor Author

ccfishk commented Jun 23, 2021

revert to draft since is just a holder for document the idea.

@shaneutt
Copy link
Contributor

shaneutt commented Jul 8, 2021

should we close this now that #1488 exists? It seems like we're not going to write a KEP anymore, instead we have the tests and some follow up issues which will suffice?

We did discussion, documentation and scope on #1197. #1488 is follow up concrete implementaion.

@ccfishk
Copy link
Contributor Author

ccfishk commented Jul 8, 2021

should we close this now that #1488 exists? It seems like we're not going to write a KEP anymore, instead we have the tests and some follow up issues which will suffice?

We did discussion, documentation and scope on #1197. #1488 is follow up concrete implementation.

@ccfishk
Copy link
Contributor Author

ccfishk commented Jul 8, 2021

The actual KEP work is documented in #1197

@ccfishk ccfishk closed this Jul 8, 2021
@shaneutt shaneutt deleted the ccfishk-patch-2 branch October 27, 2021 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants