-
Notifications
You must be signed in to change notification settings - Fork 593
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: datarace in datarace test #1518
Conversation
0953377
to
d9a5725
Compare
Codecov Report
@@ Coverage Diff @@
## next #1518 +/- ##
==========================================
+ Coverage 51.45% 51.53% +0.07%
==========================================
Files 91 91
Lines 6316 6316
==========================================
+ Hits 3250 3255 +5
+ Misses 2772 2769 -3
+ Partials 294 292 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
conditional lgtm if all suggestions get applied
Co-authored-by: Michał Flendrich <michal@flendrich.pro>
This fixes a really ironic bug found in our unit tests.