Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: datarace in datarace test #1518

Merged
merged 4 commits into from
Jul 9, 2021
Merged

Conversation

shaneutt
Copy link
Contributor

@shaneutt shaneutt commented Jul 8, 2021

This fixes a really ironic bug found in our unit tests.

@shaneutt shaneutt added bug Something isn't working priority/low labels Jul 8, 2021
@shaneutt shaneutt self-assigned this Jul 8, 2021
@shaneutt shaneutt requested a review from a team as a code owner July 8, 2021 21:20
@shaneutt shaneutt temporarily deployed to Configure ci July 8, 2021 21:20 Inactive
@shaneutt shaneutt force-pushed the fix-datarace-in-datarace-tests branch from 0953377 to d9a5725 Compare July 8, 2021 21:22
@shaneutt shaneutt temporarily deployed to Configure ci July 8, 2021 21:22 Inactive
@shaneutt shaneutt temporarily deployed to Configure ci July 8, 2021 21:22 Inactive
@codecov
Copy link

codecov bot commented Jul 8, 2021

Codecov Report

Merging #1518 (9b3d598) into next (4125d78) will increase coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             next    #1518      +/-   ##
==========================================
+ Coverage   51.45%   51.53%   +0.07%     
==========================================
  Files          91       91              
  Lines        6316     6316              
==========================================
+ Hits         3250     3255       +5     
+ Misses       2772     2769       -3     
+ Partials      294      292       -2     
Flag Coverage Δ
integration-test 48.51% <ø> (+0.23%) ⬆️
unit-test 38.93% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...trollers/configuration/zz_generated_controllers.go 48.41% <0.00%> (+0.57%) ⬆️
railgun/internal/ctrlutils/ingress-status.go 62.93% <0.00%> (+1.29%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4125d78...9b3d598. Read the comment docs.

Copy link
Contributor

@mflendrich mflendrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

conditional lgtm if all suggestions get applied

Co-authored-by: Michał Flendrich <michal@flendrich.pro>
@shaneutt shaneutt temporarily deployed to Configure ci July 8, 2021 21:36 Inactive
@shaneutt shaneutt temporarily deployed to Configure ci July 8, 2021 21:36 Inactive
@shaneutt shaneutt temporarily deployed to Configure ci July 8, 2021 21:36 Inactive
@shaneutt shaneutt temporarily deployed to Configure ci July 9, 2021 00:51 Inactive
@shaneutt shaneutt temporarily deployed to Configure ci July 9, 2021 00:51 Inactive
@shaneutt shaneutt merged commit f42f1c9 into next Jul 9, 2021
@shaneutt shaneutt deleted the fix-datarace-in-datarace-tests branch July 9, 2021 00:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants