Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(change) add breaking finalizer change info #1555

Merged
merged 1 commit into from
Jul 15, 2021
Merged

Conversation

rainest
Copy link
Contributor

@rainest rainest commented Jul 15, 2021

What this PR does / why we need it:
Documentation for the breaking finalizer changes in #1522. This change requires manual cleanup if you used previous 2.x alpha releases.

PR Readiness Checklist:

Complete these before marking the PR as ready to review:

  • the CHANGELOG.md release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR

@rainest rainest requested a review from a team as a code owner July 15, 2021 16:56
@rainest rainest temporarily deployed to Configure ci July 15, 2021 16:56 Inactive
@codecov
Copy link

codecov bot commented Jul 15, 2021

Codecov Report

Merging #1555 (e365d67) into next (5d72031) will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             next    #1555      +/-   ##
==========================================
+ Coverage   50.48%   50.52%   +0.04%     
==========================================
  Files          92       92              
  Lines        6440     6440              
==========================================
+ Hits         3251     3254       +3     
+ Misses       2881     2879       -2     
+ Partials      308      307       -1     
Flag Coverage Δ
integration-test 45.32% <ø> (+0.13%) ⬆️
unit-test 38.55% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
railgun/internal/ctrlutils/ingress-status.go 63.67% <0.00%> (+1.28%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d72031...e365d67. Read the comment docs.

Copy link
Contributor

@shaneutt shaneutt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙇

@rainest rainest merged commit 974368b into next Jul 15, 2021
@rainest rainest deleted the doc/finalizer branch July 15, 2021 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants