[fix] disable proxy backpressure mechanism #1612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shaneutt
added
priority/high
area/maintenance
3 tasks
3 tasks
ccfishk
reviewed
Jul 30, 2021
shaneutt
force-pushed
the
disable-proxy-backpressure
branch
from
69ac1e2 to
ed57d0e
Compare
shaneutt
force-pushed
the
disable-proxy-backpressure
branch
from
ed57d0e to
4ca545e
Compare
shaneutt
changed the title
shaneutt
force-pushed
the
disable-proxy-backpressure
branch
from
4ca545e to
d7e8b52
Compare
shaneutt
force-pushed
the
disable-proxy-backpressure
branch
from
fca7f82 to
88aabf6
Compare
shaneutt
force-pushed
the
disable-proxy-backpressure
branch
from
88aabf6 to
6cf9018
Compare
shaneutt
force-pushed
the
disable-proxy-backpressure
branch
from
6cf9018 to
8725a6b
Compare
rainest
approved these changes
Jul 30, 2021
There was a problem hiding this comment.
Per test update in #1519 (comment) this does what we want and does not cause obvious issues.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Based on the investigation and report in #1519 this patch disables the backpressure system that was introduced during the alpha stage which intended to try and help highlight kong proxy backend issues to operators. The findings were that the tradeoffs in performance didn't justify the value added and that for the moment we are going to make this work more like v1.x did for consistency and perhaps look at improvements in this area again in a later iteration.
Which issue this PR fixes
Supports #1519