Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] legacy fixes & release tests for v1.17 & v1.18 #1630

Merged
merged 4 commits into from
Aug 2, 2021

Conversation

shaneutt
Copy link
Contributor

@shaneutt shaneutt commented Aug 2, 2021

What this PR does / why we need it:

  • fixes broken compatibility with legacy Ingress from netv1beta1 & extv1beta1
  • enables release testing against v1.17 and v1.18 clusters

Which issue this PR fixes

Supports #1095
Resolves #1614

Special notes for your reviewer:

These changes have been tested:

old-k8s-tests

@shaneutt shaneutt requested a review from a team as a code owner August 2, 2021 17:35
@shaneutt shaneutt self-assigned this Aug 2, 2021
@shaneutt shaneutt linked an issue Aug 2, 2021 that may be closed by this pull request
1 task
@shaneutt shaneutt force-pushed the release-test-old-k8s branch from b647dd6 to 32ae71b Compare August 2, 2021 17:36
@shaneutt shaneutt enabled auto-merge (rebase) August 2, 2021 17:38
@codecov
Copy link

codecov bot commented Aug 2, 2021

Codecov Report

Merging #1630 (b057d74) into next (d4a3376) will decrease coverage by 0.17%.
The diff coverage is 11.53%.

Impacted file tree graph

@@            Coverage Diff             @@
##             next    #1630      +/-   ##
==========================================
- Coverage   62.17%   61.99%   -0.18%     
==========================================
  Files          82       82              
  Lines        7172     7241      +69     
==========================================
+ Hits         4459     4489      +30     
- Misses       2384     2419      +35     
- Partials      329      333       +4     
Flag Coverage Δ
integration-test 61.99% <11.53%> (-0.18%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...trollers/configuration/zz_generated_controllers.go 33.95% <0.00%> (+1.35%) ⬆️
internal/ctrlutils/utils.go 88.46% <0.00%> (-5.29%) ⬇️
internal/store/store.go 65.72% <0.00%> (+0.01%) ⬆️
internal/ctrlutils/ingress-status.go 52.24% <13.63%> (-7.76%) ⬇️
internal/parser/parser.go 87.67% <0.00%> (-1.15%) ⬇️
...entset/typed/configuration/v1/kongclusterplugin.go 23.25% <0.00%> (+8.13%) ⬆️
pkg/clientset/typed/configuration/v1/kongplugin.go 24.21% <0.00%> (+8.42%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d4a3376...b057d74. Read the comment docs.

@shaneutt shaneutt force-pushed the release-test-old-k8s branch from 32ae71b to b057d74 Compare August 2, 2021 17:58
@shaneutt shaneutt requested a review from rainest August 2, 2021 18:02
@shaneutt shaneutt merged commit 937fff3 into next Aug 2, 2021
@shaneutt shaneutt deleted the release-test-old-k8s branch August 2, 2021 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Legacy Ingress for KIC 2.0
2 participants