Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: avoid nil pointer reference when overriding route with KongIngress #188

Merged
merged 1 commit into from
Nov 1, 2018
Merged

fix: avoid nil pointer reference when overriding route with KongIngress #188

merged 1 commit into from
Nov 1, 2018

Conversation

hbagdi
Copy link
Member

@hbagdi hbagdi commented Oct 30, 2018

See: #186

@hbagdi hbagdi requested a review from fffonion October 30, 2018 00:11
@codecov-io
Copy link

codecov-io commented Oct 30, 2018 •
edited
Loading

Codecov Report

Merging #188 into master will increase coverage by 1.83%.
The diff coverage is 68.18%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #188      +/-   ##
==========================================
+ Coverage   18.86%   20.69%   +1.83%     
==========================================
  Files          24       24              
  Lines        2322     2319       -3     
==========================================
+ Hits          438      480      +42     
+ Misses       1846     1798      -48     
- Partials       38       41       +3
Impacted Files Coverage Δ
internal/ingress/controller/kong.go 1.13% <0%> (+0.06%) ⬆️
internal/ingress/controller/util.go 52.5% <81.08%> (+52.5%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 894e966...6c049ae. Read the comment docs.

@hbagdi hbagdi mentioned this pull request Oct 30, 2018
Closed
fffonion
fffonion approved these changes Oct 31, 2018
View reviewed changes
Copy link
Contributor

@fffonion fffonion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@hbagdi hbagdi merged commit 369c10a into master Nov 1, 2018
@hbagdi hbagdi deleted the fix/nil-reference branch November 1, 2018 19:43
hbagdi added a commit that referenced this pull request Nov 8, 2018
@hbagdi
fix: avoid nil pointer reference when overriding route with KongIngress
41991d9 
ca2c087 changed the underlying library being
used for interacting with Kong.
It also introduced this bug where a nil reference
was possible.
The code has been refactored
and includes a test.
This is a stop-gap solution
till we have the bigger refactor
in place and make the code
clean and testable.

See: #186
From #188
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fffonion fffonion fffonion approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hbagdi @codecov-io @fffonion