fix: reduce gh actions job resource contention for istio e2e #2073
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shaneutt
changed the title
rainest
approved these changes
Dec 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This patch disallows multiple cluster deployments in the nightly E2E tests to see if this helps with Istio test flakes.
Which issue this PR fixes
Partially Resolves #2071
Special notes for your reviewer:
While I was able to reproduce and start work on the non-Istio test failures from #2071, I could not reproduce the Istio test failures on my local machine. As such I would like to see if those tests start passing consistently if there's less resource contention in the environment, because it is already known that the actions of the test (to deploy all of istio then perform large numbers of network requests) are resource intensive.