Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): cleanup gke related scripts #3399

Merged
merged 1 commit into from
Jan 18, 2023
Merged

chore(ci): cleanup gke related scripts #3399

merged 1 commit into from
Jan 18, 2023

Conversation

czeslavo
Copy link
Contributor

@czeslavo czeslavo commented Jan 18, 2023

What this PR does / why we need it:

  • Removes unused deploy.go script and Makefile targets
  • Turns cleanup.go into cleanup_gke_clusters.go with a single purpose of being used in the cleanup.yml workflow
  • Removes the concurrency property from workflows as it's proven to not work well in our case (it doesn't allow queueing more than 1 job, more on that in the discussion). In order to mitigate the possible issue with clusters being deleted by the cleanup job before E2E tests are finished, clusters are considered orphaned after 1h from their creation (instead of 30min).

Which issue this PR fixes:

Part of #3378.

@czeslavo czeslavo self-assigned this Jan 18, 2023
@czeslavo czeslavo temporarily deployed to gcloud January 18, 2023 16:52 — with GitHub Actions Inactive
@czeslavo czeslavo temporarily deployed to gcloud January 18, 2023 16:52 — with GitHub Actions Inactive
@czeslavo czeslavo temporarily deployed to gcloud January 18, 2023 16:52 — with GitHub Actions Inactive
@czeslavo czeslavo temporarily deployed to gcloud January 18, 2023 16:52 — with GitHub Actions Inactive
@czeslavo czeslavo temporarily deployed to gcloud January 18, 2023 16:52 — with GitHub Actions Inactive
@czeslavo czeslavo temporarily deployed to gcloud January 18, 2023 16:52 — with GitHub Actions Inactive
@czeslavo czeslavo temporarily deployed to gcloud January 18, 2023 16:52 — with GitHub Actions Inactive
@czeslavo czeslavo temporarily deployed to gcloud January 18, 2023 16:52 — with GitHub Actions Inactive
@czeslavo czeslavo temporarily deployed to gcloud January 18, 2023 16:52 — with GitHub Actions Inactive
@czeslavo czeslavo temporarily deployed to gcloud January 18, 2023 16:52 — with GitHub Actions Inactive
@czeslavo czeslavo temporarily deployed to gcloud January 18, 2023 16:52 — with GitHub Actions Inactive
@czeslavo czeslavo temporarily deployed to gcloud January 18, 2023 16:52 — with GitHub Actions Inactive
@czeslavo czeslavo temporarily deployed to gcloud January 18, 2023 16:52 — with GitHub Actions Inactive
@czeslavo czeslavo temporarily deployed to gcloud January 18, 2023 16:52 — with GitHub Actions Inactive
@czeslavo czeslavo temporarily deployed to gcloud January 18, 2023 16:52 — with GitHub Actions Inactive
@codecov
Copy link

codecov bot commented Jan 18, 2023

Codecov Report

Base: 73.8% // Head: 73.9% // Increases project coverage by +0.0% 🎉

Coverage data is based on head (6fb829c) compared to base (6d755ef).
Patch has no changes to coverable lines.

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #3399   +/-   ##
=====================================
  Coverage   73.8%   73.9%           
=====================================
  Files        113     113           
  Lines      13896   13896           
=====================================
+ Hits       10266   10278   +12     
+ Misses      2977    2966   -11     
+ Partials     653     652    -1     
Impacted Files Coverage Δ
...nternal/controllers/gateway/tcproute_controller.go 70.0% <0.0%> (-2.0%) ⬇️
internal/dataplane/parser/parser.go 89.6% <0.0%> (-1.7%) ⬇️
internal/dataplane/kongstate/service.go 66.0% <0.0%> (-1.3%) ⬇️
internal/controllers/gateway/gateway_utils.go 90.4% <0.0%> (+0.4%) ⬆️
internal/controllers/gateway/gateway_controller.go 67.9% <0.0%> (+1.1%) ⬆️
...ternal/controllers/gateway/httproute_controller.go 60.1% <0.0%> (+1.5%) ⬆️
...nternal/controllers/gateway/udproute_controller.go 71.6% <0.0%> (+2.1%) ⬆️
internal/util/builder/routenamespaces.go 71.4% <0.0%> (+21.4%) ⬆️
internal/util/builder/allowedroutes.go 100.0% <0.0%> (+50.0%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@czeslavo czeslavo marked this pull request as ready for review January 18, 2023 17:47
@czeslavo czeslavo requested a review from a team as a code owner January 18, 2023 17:47
hack/cleanup_gke_clusters.go Show resolved Hide resolved
@czeslavo czeslavo merged commit bf32874 into main Jan 18, 2023
@czeslavo czeslavo deleted the chore/gke-cleanup branch January 18, 2023 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants