-
Notifications
You must be signed in to change notification settings - Fork 594
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(ci): cleanup gke related scripts #3399
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 73.8% // Head: 73.9% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #3399 +/- ##
=====================================
Coverage 73.8% 73.9%
=====================================
Files 113 113
Lines 13896 13896
=====================================
+ Hits 10266 10278 +12
+ Misses 2977 2966 -11
+ Partials 653 652 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
czeslavo
force-pushed
the
chore/gke-cleanup
branch
from
January 18, 2023 17:42
54f28d9
to
6fb829c
Compare
pmalek
approved these changes
Jan 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
deploy.go
script and Makefile targetscleanup.go
intocleanup_gke_clusters.go
with a single purpose of being used in thecleanup.yml
workflowconcurrency
property from workflows as it's proven to not work well in our case (it doesn't allow queueing more than 1 job, more on that in the discussion). In order to mitigate the possible issue with clusters being deleted by the cleanup job before E2E tests are finished, clusters are considered orphaned after 1h from their creation (instead of 30min).Which issue this PR fixes:
Part of #3378.