-
Notifications
You must be signed in to change notification settings - Fork 594
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(httproute): add ReferenceGrant
watch
#3759
Conversation
ReferenceGrant
watch
ac5a4d7
to
7d6f636
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #3759 +/- ##
=======================================
+ Coverage 0 58.9% +58.9%
=======================================
Files 0 134 +134
Lines 0 15751 +15751
=======================================
+ Hits 0 9291 +9291
- Misses 0 5825 +5825
- Partials 0 635 +635
... and 130 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
Actually let me add a test for that |
7d6f636
to
bdb14e7
Compare
bdb14e7
to
685e2bf
Compare
685e2bf
to
a6a8f0e
Compare
9d18ca3
to
667bc78
Compare
15959ec
to
79b8782
Compare
internal/controllers/gateway/httproute_controller_envtest_test.go
Outdated
Show resolved
Hide resolved
internal/controllers/gateway/httproute_controller_envtest_test.go
Outdated
Show resolved
Hide resolved
79b8782
to
76b31e1
Compare
d3de5a2
to
db23878
Compare
db23878
to
f1660f7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My own merge contains a minor conflict fix in CHANGELOG.md. My kingdom for some sort of automation around that to just say "always accept both for this file", but whatever. Re-approving based on the previous approval.
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-release/2.9.x release/2.9.x
# Navigate to the new working tree
cd .worktrees/backport-release/2.9.x
# Create a new branch
git switch --create backport-3759-to-release/2.9.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 d11292b10fd5366ae5f6b4e3083e2b05112d6d00
# Push it to GitHub
git push --set-upstream origin backport-3759-to-release/2.9.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-release/2.9.x Then, create a pull request where the |
Co-authored-by: Grzegorz Burzyński <czeslavo@gmail.com> Co-authored-by: Travis Raines <571832+rainest@users.noreply.github.com> (cherry picked from commit d11292b)
Co-authored-by: Grzegorz Burzyński <czeslavo@gmail.com> Co-authored-by: Travis Raines <571832+rainest@users.noreply.github.com> (cherry picked from commit d11292b)
What this PR does / why we need it:
This PR adds a watch for
ReferenceGrant
in HTTPRouteController.With this change when a
ReferenceGrant
is deleted, the HTTPRoute gets its status update with a condition:type: ResolvedRefs
,reason: RefNotPermitted
andstatus
set to"False"
.Which issue this PR fixes:
Related: #3289
Apart from the above this will also make us pass this conformance test (yet to merged): kubernetes-sigs/gateway-api#1853