Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(tests): workaround to not rely on helpers from KTF #3980

Merged
merged 1 commit into from
May 11, 2023

Conversation

programmer04
Copy link
Member

@programmer04 programmer04 commented May 9, 2023

What this PR does / why we need it:

This PR copies code for helpers waitForServiceLoadBalancerAddress & waitForConnectionOnServicePort from already merged PR Kong/kubernetes-testing-framework#643 in KTF project. This is a temporary solution. The purpose is to have helpers that use EndpointSlices API without upgrading the KTF version. Currently, upgrading is hard due to a dependencies mismatch. If you would like to learn more check issue #3981. It will be reverted when we are able to upgrade KTF.

Which issue this PR fixes:

It's needed to finish #3916

@codecov
Copy link

codecov bot commented May 9, 2023

Codecov Report

Patch coverage has no change and project coverage change: +15.4 🎉

Comparison is base (35de761) 58.8% compared to head (2d8ae3d) 74.3%.

Additional details and impacted files
@@           Coverage Diff            @@
##            main   #3980      +/-   ##
========================================
+ Coverage   58.8%   74.3%   +15.4%     
========================================
  Files        142     142              
  Lines      15996   15996              
========================================
+ Hits        9416   11894    +2478     
+ Misses      5950    3355    -2595     
- Partials     630     747     +117     

see 44 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@programmer04 programmer04 force-pushed the port-helper-from-ktf branch 4 times, most recently from f60ce9e to d939990 Compare May 11, 2023 09:16
@programmer04 programmer04 marked this pull request as ready for review May 11, 2023 13:43
@programmer04 programmer04 removed the work in progress Work In Progress label May 11, 2023
@czeslavo czeslavo requested a review from a team May 11, 2023 15:13
Copy link
Contributor

@czeslavo czeslavo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Makes sense to me to overcome the KTF issue this way.

@programmer04 Have you explicitly removed the team-k8s-maintainers from reviewers of this PR? I cannot see such an event logged in the PR, while the codeowners should be added as reviewers automatically. I ask because I haven't got a notification for this. Maybe it's because of the recent GH's problems with their services 🤔

@programmer04 programmer04 enabled auto-merge (squash) May 11, 2023 15:22
@programmer04
Copy link
Member Author

@czeslavo good catch! Nope I think it's GH issue, when I marked this as ready for review I got 500, but it became ready for review 😅

@pmalek
Copy link
Member

pmalek commented May 11, 2023

It seems that some of the tests are failing 🤔 I don't believe this could possibly be related and if that's the case we should note down the tests and create issue(s) for them.

@programmer04
Copy link
Member Author

Yeah, I experienced flakiness today. I've created the issue already #3992. But here is something else, it happened for postgres suite too, but after re-run it passed. I'm going to create a dedicated issue for this

@programmer04 programmer04 merged commit 86a3c0f into main May 11, 2023
@programmer04 programmer04 deleted the port-helper-from-ktf branch May 11, 2023 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants