tests: delete migrations job before upgrade in e2e test #4100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #4100 +/- ##
=======================================
+ Coverage 60.1% 60.3% +0.1%
=======================================
Files 150 150
Lines 16727 16736 +9
=======================================
+ Hits 10066 10100 +34
+ Misses 6024 6001 -23
+ Partials 637 635 -2 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
To prevent failures caused by not being allowed to update jobs' spec when upgrading with
kubectl apply -fto a newer version of all-in-one manifests, delete the job just before the upgrade.Which issue this PR fixes:
Fixes #4097.
Special notes for your reviewer:
We agreed to use
generateName, but unfortunately it's not supported by Kustomize (see the issue: kubernetes-sigs/kustomize#641). I also tried going with using Kustomize'sreplacementsto use the deployment's image tag to append a version-dependent suffix to the migration job's name, but it didn't work either due to deployment not being rendered at that stage yet. I decided to not spend more time on it and just go with a simple delete in the test.