Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests(integration): remove clusterVersion and test skipping code for EOLd k8s versions #4761

Merged
merged 1 commit into from
Sep 29, 2023

Conversation

pmalek
Copy link
Member

@pmalek pmalek commented Sep 29, 2023

What this PR does / why we need it:

Code that was using clusterVersion was mostly around skipping tests for k8s <=1.21 or <1.19 and since we don't tests on those versions anymore we can get rid of that.

@pmalek pmalek added area/tests area/maintenance Cleanup, refactoring, and other maintenance improvements that don't change functionality. labels Sep 29, 2023
@pmalek pmalek added this to the Fixit 2023 milestone Sep 29, 2023
@pmalek pmalek self-assigned this Sep 29, 2023
@codecov
Copy link

codecov bot commented Sep 29, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (2941d85) 77.6% compared to head (f7dcfb3) 77.6%.

Additional details and impacted files
@@           Coverage Diff           @@
##            main   #4761     +/-   ##
=======================================
- Coverage   77.6%   77.6%   -0.1%     
=======================================
  Files        163     163             
  Lines      18665   18665             
=======================================
- Hits       14492   14491      -1     
- Misses      3356    3358      +2     
+ Partials     817     816      -1     

see 7 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pmalek pmalek force-pushed the integration-tests-remove-cluster-version branch from ea7156b to f7dcfb3 Compare September 29, 2023 13:29
@pull-request-size pull-request-size bot added size/S and removed size/M labels Sep 29, 2023
@pmalek pmalek marked this pull request as ready for review September 29, 2023 13:55
@pmalek pmalek requested a review from a team as a code owner September 29, 2023 13:55
@pmalek pmalek merged commit 658b43d into main Sep 29, 2023
42 checks passed
@pmalek pmalek deleted the integration-tests-remove-cluster-version branch September 29, 2023 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/maintenance Cleanup, refactoring, and other maintenance improvements that don't change functionality. area/tests size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants