feat: don't configure Kong Gateways with incompatible router flavor #5040
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #5040 +/- ##
=======================================
- Coverage 75.4% 75.4% -0.1%
=======================================
Files 167 167
Lines 18906 18942 +36
=======================================
+ Hits 14273 14287 +14
- Misses 3803 3823 +20
- Partials 830 832 +2 ☔ View full report in Codecov by Sentry. |
pmalek
force-pushed
the
warn-users-when-incompatible-router-flavor-is-detected
branch
from
51acbbb to
d164a57
Compare
pmalek
commented
Nov 6, 2023
| @@ -22,14 +23,14 @@ func TestValidateRoots(t *testing.T) { | |||
| name string | |||
| configStr string | |||
| expectedDBMode string | |||
| expectedRouterFlavor string | |||
| expectedRouterFlavor configuration.RouterFlavor | |||
There was a problem hiding this comment.
Will wait for #5092 to not cause conflicts
1 task
|
Waiting for #5092 to reuse the introduced |
|
On hold for now pending the work on Gateway side (slack thread link in #5018's description): summary #5018 (comment). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Warn users in logs when Kong Gateway with incompatible router is detected and reject the client for that Gateway when sending out the configuration.
Which issue this PR fixes:
Related: #5018
Special notes for your reviewer:
PR Readiness Checklist:
Complete these before marking the PR as
ready to review:CHANGELOG.mdrelease notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR