test(e2e): set appProtocol to HTTP for kuma tests #5507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
randmonkey
added
area/kong
|
E2E (targeted) tests with KIND-based clusters were started at https://github.com/Kong/kubernetes-ingress-controller/actions/runs/7722704065 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5507 +/- ##
=======================================
- Coverage 69.8% 69.8% -0.1%
=======================================
Files 176 176
Lines 22873 22873
=======================================
- Hits 15981 15968 -13
- Misses 5950 5963 +13
Partials 942 942 ☔ View full report in Codecov by Sentry. |
czeslavo
reviewed
Jan 31, 2024
Co-authored-by: Grzegorz Burzyński <czeslavo@gmail.com>
czeslavo
previously approved these changes
Jan 31, 2024
czeslavo
approved these changes
Jan 31, 2024
rainest
pushed a commit
that referenced
this pull request
Mar 28, 2024
* set appProtocol to HTTP for kuma tests * Update test/e2e/helpers_test.go Co-authored-by: Grzegorz Burzyński <czeslavo@gmail.com> --------- Co-authored-by: Grzegorz Burzyński <czeslavo@gmail.com>
team-k8s-bot
pushed a commit
that referenced
this pull request
Apr 29, 2024
* set appProtocol to HTTP for kuma tests * Update test/e2e/helpers_test.go Co-authored-by: Grzegorz Burzyński <czeslavo@gmail.com> --------- Co-authored-by: Grzegorz Burzyński <czeslavo@gmail.com> (cherry picked from commit 72cb3b1)
randmonkey
added a commit
that referenced
this pull request
Apr 30, 2024
* set appProtocol to HTTP for kuma tests * Update test/e2e/helpers_test.go Co-authored-by: Grzegorz Burzyński <czeslavo@gmail.com> --------- Co-authored-by: Grzegorz Burzyński <czeslavo@gmail.com> (cherry picked from commit 72cb3b1) Co-authored-by: Tao Yi <tao.yi@konghq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
As discussed internally, setting
appProtocoltoHTTPwill make kuma to load balance at request level. While by default kuma may only load balance at the connection level. When Kong gateway changed theupstream_keepalive_max_requestsfrom 1000 to 10000: Kong/kong#12223, the upstream connection is reused during all the test which only send about 3000 requests. So the requests constantly go to the same backend pod from one Kong gateway pod.I changed
appProtocoltohttp, the failure disappears in my local run.Which issue this PR fixes:
maybe fix #5498
Special notes for your reviewer:
PR Readiness Checklist:
Complete these before marking the PR as
ready to review:- [ ] theNo changelog requiredCHANGELOG.mdrelease notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR