Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix the building part in CONTRIBUTING.md #768

Merged
merged 4 commits into from
Jul 15, 2020
Merged

docs: fix the building part in CONTRIBUTING.md #768

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b544b37
docs: fix the building part in CONTRIBUTING.md
yuchunyu97 Jul 9, 2020
7f34ff0
docs: remove extra characters in CONTRIBUTING.md
yuchunyu97 Jul 10, 2020
dc653d5
add docker push
yuchunyu97 Jul 15, 2020
bf3abb5
uniform the docker image name when build and push
yuchunyu97 Jul 15, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ $ make build
### Build a local container image

```console
$ TAG=DEV make docker-build
$ TAG=DEV REGISTRY=docker.example.com/registry make container
```

Note: this will use the Docker daemon
Expand All @@ -107,9 +107,11 @@ in your Deployment specs.
### Push the container image to a remote repository

```console
$ TAG=DEV REGISTRY=$USER/kong-ingress-controller make docker-push
$ docker push docker.example.com/registry/kong-ingress-controller:DEV
```

Note: replace `docker.example.com/registry` with your registry URL.

## Deploying

There are several ways to deploy Kong Ingress Controller onto a cluster.
Expand Down