Add override support for Knative Services

[rafaelfelix]

What this PR does / why we need it: Add override support for Knative Services

Which issue this PR fixes: fixes #838

Special notes for your reviewer:

[CLAassistant]

All committers have signed the CLA.

[mflendrich]

Hi @rafaelfelix,

Thanks for your contribution!

Could you please add a test under parser_test.go for cases where a Knative Ingress has, and doesn't have, an override annotation?

For reference, you can reuse TestKnativeIngressAndPlugins: create a test like this:

• Arrange: create a NewFakeStore() with a KnativeIngress and a KongIngress therein,
• Act: Build(logger, fakestore)
• Assert: that the resulting KongState object has the expected overrides in place

[rafaelfelix]

hi @mflendrich! just pushed the tests as requested. let me know if there's any other case we gotta cover :) thanks

[mflendrich]

Looks good to me!

@hbagdi , is there anything we've missed that needs attention? You're more familiar with the issue than I am. If it's good to go, please merge 🔥

[rafaelfelix]

@hbagdi, @mflendrich please review again whenever you have time. Thanks

The base branch was changed.

[hbagdi]

@rafaelfelix This needs to target the next branch. Could you please rebase your branch on top of next?

[rafaelfelix]

@hbagdi just rebased my branch with next and force-pushed. please review again when you have some time.

thank you

[hbagdi]

It is interesting to see how a single line patch can add this functionality now.

[hbagdi]

Thank you for your contribution. Please fill out the following form to claim your contributor swag:
https://github.com/Kong/kong/blob/master/CONTRIBUTING.md#contributor-t-shirt.