fix: adapt to kong chart v2.39 #1105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1105 +/- ##
==========================================
- Coverage 60.21% 60.11% -0.10%
==========================================
Files 50 50
Lines 4079 4082 +3
==========================================
- Hits 2456 2454 -2
- Misses 1313 1318 +5
Partials 310 310
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
czeslavo
force-pushed
the
fix/adapt-to-kong-chart
branch
from
f8ca5b8 to
35b37c9
Compare
1 task
pmalek
approved these changes
Jun 17, 2024
programmer04
approved these changes
Jun 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
kong/kongchart from v2.39 no longer sets the default value ofenterprise.rbac.session_conf_secret(Kong/charts#1033). This PR fixes an issue discovered in KIC's integration tests (Kong/kubernetes-ingress-controller#6198) that makes Kong complain about missingadmin_gui_session_confcaused by KTF relying on the default in charts.Tested in Kong/kubernetes-ingress-controller#6198 by manual KTF bump to this branch.