feat: add flag to enable LB SVC for kong admin in CLI #245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #245 +/- ##
=======================================
Coverage 11.75% 11.75%
=======================================
Files 5 5
Lines 604 604
=======================================
Hits 71 71
Misses 528 528
Partials 5 5 Continue to review full report at Codecov.
|
rainest
approved these changes
Mar 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just something I do manually with a fair amount of frequency so I figured I would add it to the CLI.
In time we do need to change how the CLI is structured so that flags belong to the addon component instead of being general to environment creation, but for the moment this is just a quick add that provides a lot of value for running tests.