Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Kong diagnostic config dumps #334

Merged
merged 8 commits into from
Aug 1, 2022
Merged

Improve Kong diagnostic config dumps #334

merged 8 commits into from
Aug 1, 2022

Conversation

rainest
Copy link
Contributor

@rainest rainest commented Jul 28, 2022

Update the Kong addon's diagnostics to:

  • Extract DB-less config YAML from the mangled admin API JSON response.
  • Add support for DB-backed config using decK parts.

Added 0.17 changelog since I'd like to try and figure out what the heck is going on with the frequent nightly Kong test failures and the tests that flake on their own, and I assume we want the CNI stuff available for the operator.

ktf-diag-2409850005.tar.gz is example Postgres (Enterprise) output.
ktf-diag-2834659457.tar.gz shows the updated DB-less output.

@rainest rainest requested a review from a team as a code owner July 28, 2022 23:00
@rainest rainest force-pushed the feat/kong-config branch from eba141c to c300151 Compare July 28, 2022 23:02
@rainest rainest temporarily deployed to integration-tests July 28, 2022 23:02 Inactive
@rainest rainest force-pushed the feat/kong-config branch from c300151 to a96b249 Compare July 28, 2022 23:07
@rainest rainest temporarily deployed to integration-tests July 28, 2022 23:07 Inactive
@codecov-commenter
Copy link

codecov-commenter commented Jul 28, 2022

Codecov Report

Merging #334 (2057998) into main (fd088f5) will decrease coverage by 1.04%.
The diff coverage is 0.00%.

@@            Coverage Diff            @@
##             main    #334      +/-   ##
=========================================
- Coverage   10.28%   9.24%   -1.05%     
=========================================
  Files           5       5              
  Lines         690     768      +78     
=========================================
  Hits           71      71              
- Misses        614     692      +78     
  Partials        5       5              
Impacted Files Coverage Δ
pkg/clusters/addons/kong/addon.go 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fd088f5...2057998. Read the comment docs.

@rainest rainest enabled auto-merge (squash) July 28, 2022 23:27
@rainest rainest temporarily deployed to integration-tests July 29, 2022 17:19 Inactive
Copy link
Contributor

@shaneutt shaneutt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It occurs to me that we're missing tests for this stuff entirely. Can we add some basic tests so that we can help prevent regressions where we might break the dumps in the future?

CHANGELOG.md Outdated Show resolved Hide resolved
rainest added 2 commits July 29, 2022 14:50
Add support for dumping Postgres-backed instances using decK invocation.

Extract YAML config from DB-less config endpoint.
@rainest rainest force-pushed the feat/kong-config branch from 46dcf11 to 3df1d20 Compare July 29, 2022 21:51
@rainest rainest had a problem deploying to integration-tests July 29, 2022 21:52 Failure
@rainest rainest disabled auto-merge July 29, 2022 21:52
@rainest rainest enabled auto-merge (squash) July 29, 2022 21:53
@rainest rainest force-pushed the feat/kong-config branch from 3df1d20 to 20eea10 Compare July 29, 2022 22:25
@rainest rainest had a problem deploying to integration-tests July 29, 2022 22:25 Failure
@rainest rainest requested a review from shaneutt July 29, 2022 22:25
@rainest rainest temporarily deployed to integration-tests July 29, 2022 23:23 Inactive
@rainest
Copy link
Contributor Author

rainest commented Jul 29, 2022

2057998 piggybacks on this since it's hopefully small enough and avoids waiting for the changelog update in a separate PR. While converting some of the problem KIC tests to use this system, I realized that we couldn't get the correct defer ordering for examples tests, since those need to delete YAML instead of resources, and the cleaner lacked support for that.

@rainest rainest force-pushed the feat/kong-config branch from 871f7f7 to 2057998 Compare July 29, 2022 23:38
@rainest rainest temporarily deployed to integration-tests July 29, 2022 23:38 Inactive
pkg/clusters/addons/kong/addon.go Outdated Show resolved Hide resolved
pkg/clusters/addons/kong/addon.go Outdated Show resolved Hide resolved
@rainest rainest temporarily deployed to integration-tests August 1, 2022 22:53 Inactive
@rainest rainest merged commit 633ccee into main Aug 1, 2022
@rainest rainest deleted the feat/kong-config branch August 1, 2022 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants