-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Kong diagnostic config dumps #334
Conversation
eba141c
to
c300151
Compare
c300151
to
a96b249
Compare
Codecov Report
@@ Coverage Diff @@
## main #334 +/- ##
=========================================
- Coverage 10.28% 9.24% -1.05%
=========================================
Files 5 5
Lines 690 768 +78
=========================================
Hits 71 71
- Misses 614 692 +78
Partials 5 5
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It occurs to me that we're missing tests for this stuff entirely. Can we add some basic tests so that we can help prevent regressions where we might break the dumps in the future?
Add support for dumping Postgres-backed instances using decK invocation. Extract YAML config from DB-less config endpoint.
46dcf11
to
3df1d20
Compare
3df1d20
to
20eea10
Compare
2057998 piggybacks on this since it's hopefully small enough and avoids waiting for the changelog update in a separate PR. While converting some of the problem KIC tests to use this system, I realized that we couldn't get the correct defer ordering for examples tests, since those need to delete YAML instead of resources, and the cleaner lacked support for that. |
871f7f7
to
2057998
Compare
Update the Kong addon's diagnostics to:
Added 0.17 changelog since I'd like to try and figure out what the heck is going on with the frequent nightly Kong test failures and the tests that flake on their own, and I assume we want the CNI stuff available for the operator.
ktf-diag-2409850005.tar.gz is example Postgres (Enterprise) output.
ktf-diag-2834659457.tar.gz shows the updated DB-less output.