fix: use authenticated github client when GITHUB_TOKEN env is available #456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mlavacca
previously approved these changes
Dec 5, 2022
mlavacca
approved these changes
Dec 5, 2022
pmalek
deleted the
use-github-client-to-prevent-rate-limiting-in-tests
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that the culprit of #454 can be that we never checked the status code when querying Github for latest releases.
This patch changes the implementation to use the official github client which does account for rate limiting and properly return an error:
Additionally this introduces
context.Contextwhenever possible along the call path to allow cancellation to propagate.Fixes #454