Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix calico manifests URL #555

Merged
merged 1 commit into from
Feb 10, 2023
Merged

fix: fix calico manifests URL #555

merged 1 commit into from
Feb 10, 2023

Conversation

pmalek
Copy link
Member

@pmalek pmalek commented Feb 10, 2023

It seems that the old URL for calico manifests: https://projectcalico.docs.tigera.io/manifests/calico.yaml is not available anymore.

Calico docs explicitly mention a version in the URL so something like this has to be used: https://raw.githubusercontent.com/projectcalico/calico/v3.25.0/manifests/calico.yaml

Since these are in the repo and not attached to release artifacts we have to pick a tag or a branch. I reckon using master is not the best idea so let's stick to the latest version ATM.

Here's a CI run that has the error printed out: https://github.com/Kong/kubernetes-testing-framework/actions/runs/4144020162/jobs/7166576869

=== RUN   TestKindClusterWithCalicoCNI
=== PAUSE TestKindClusterWithCalicoCNI
=== CONT  TestKindClusterWithCalicoCNI
    calico_test.go:28: configuring the test environment with Calico enabled
    calico_test.go:31: building the testing environment and Kubernetes cluster
    calico_test.go:33: 
        	Error Trace:	/home/runner/work/kubernetes-testing-framework/kubernetes-testing-framework/test/integration/calico_test.go:33
        	Error:      	Received unexpected error:
        	            	command "/usr/local/bin/kubectl --kubeconfig /tmp/-kubeconfig-0[18](https://github.com/Kong/kubernetes-testing-framework/actions/runs/4144020162/jobs/7166576869#step:6:19)10501-bb63-4d53-bed9-b9b99a90ae582785230788 apply -f https://projectcalico.docs.tigera.io/manifests/calico.yaml" failed STDERR=() STDERR=(error: unable to read URL "https://projectcalico.docs.tigera.io/manifests/calico.yaml", server reported 404 Not Found, status code=404
        	            	): exit status 1
        	Test:       	TestKindClusterWithCalicoCNI
--- FAIL: TestKindClusterWithCalicoCNI (37.66s)

@pmalek pmalek self-assigned this Feb 10, 2023
@pmalek pmalek added the bug Something isn't working label Feb 10, 2023
@pmalek pmalek force-pushed the fix-calico-manifests-url branch from ecc5796 to 324e91c Compare February 10, 2023 13:05
@pmalek pmalek temporarily deployed to gcloud February 10, 2023 13:06 — with GitHub Actions Inactive
@pmalek pmalek marked this pull request as ready for review February 10, 2023 13:09
@pmalek pmalek requested review from a team and shaneutt as code owners February 10, 2023 13:09
@codecov-commenter
Copy link

codecov-commenter commented Feb 10, 2023

Codecov Report

Base: 52.56% // Head: 53.73% // Increases project coverage by +1.17% 🎉

Coverage data is based on head (324e91c) compared to base (6e28bcc).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #555      +/-   ##
==========================================
+ Coverage   52.56%   53.73%   +1.17%     
==========================================
  Files          50       50              
  Lines        3904     3904              
==========================================
+ Hits         2052     2098      +46     
+ Misses       1595     1546      -49     
- Partials      257      260       +3     
Flag Coverage Δ
integration-test 58.70% <100.00%> (+1.34%) ⬆️
unit-test 3.27% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/clusters/types/kind/utils.go 47.05% <100.00%> (+18.82%) ⬆️
pkg/clusters/addons/httpbin/addon.go 44.92% <0.00%> (+2.89%) ⬆️
pkg/clusters/utils.go 51.86% <0.00%> (+5.39%) ⬆️
pkg/environments/builder.go 52.77% <0.00%> (+5.55%) ⬆️
pkg/clusters/types/kind/builder.go 64.28% <0.00%> (+16.07%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@pmalek pmalek added this pull request to the merge queue Feb 10, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Feb 10, 2023
@pmalek pmalek added this pull request to the merge queue Feb 10, 2023
@pmalek pmalek removed this pull request from the merge queue due to the queue being cleared Feb 10, 2023
@pmalek pmalek merged commit 7d8bff7 into main Feb 10, 2023
@pmalek pmalek deleted the fix-calico-manifests-url branch February 10, 2023 14:34
randmonkey pushed a commit that referenced this pull request Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants