Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add machine type param to gke cluster builder #567

Merged
merged 1 commit into from
Mar 2, 2023
Merged

feat: add machine type param to gke cluster builder #567

merged 1 commit into from
Mar 2, 2023

Conversation

pmalek
Copy link
Member

@pmalek pmalek commented Feb 15, 2023

@pmalek pmalek added area/feature New feature or request area/maintenance labels Feb 15, 2023
@pmalek pmalek self-assigned this Feb 15, 2023
@pmalek pmalek force-pushed the add-machine-type-to-gke-cluster-builder branch from 62d4674 to 4f89873 Compare February 15, 2023 10:28
@pmalek pmalek temporarily deployed to gcloud February 15, 2023 10:29 — with GitHub Actions Inactive
@pmalek pmalek force-pushed the add-machine-type-to-gke-cluster-builder branch from 4f89873 to 6dd7720 Compare February 16, 2023 12:06
@pmalek pmalek temporarily deployed to gcloud February 16, 2023 12:06 — with GitHub Actions Inactive
@pmalek pmalek force-pushed the add-machine-type-to-gke-cluster-builder branch from 6dd7720 to c078597 Compare February 28, 2023 10:55
@pmalek pmalek temporarily deployed to gcloud February 28, 2023 10:55 — with GitHub Actions Inactive
@pmalek pmalek force-pushed the add-machine-type-to-gke-cluster-builder branch from c078597 to b26addc Compare March 2, 2023 08:37
@pmalek pmalek marked this pull request as ready for review March 2, 2023 08:37
@pmalek pmalek requested a review from a team as a code owner March 2, 2023 08:37
@pmalek pmalek temporarily deployed to gcloud March 2, 2023 08:37 — with GitHub Actions Inactive
@pmalek pmalek self-assigned this Mar 2, 2023
czeslavo
czeslavo previously approved these changes Mar 2, 2023
View reviewed changes
@pmalek pmalek force-pushed the add-machine-type-to-gke-cluster-builder branch from b26addc to 6634a9e Compare March 2, 2023 09:53
@pmalek pmalek requested a review from czeslavo March 2, 2023 09:53
@pmalek pmalek temporarily deployed to gcloud March 2, 2023 09:53 — with GitHub Actions Inactive
@pmalek
Copy link
Member Author

pmalek commented Mar 2, 2023

@czeslavo PTAL again. I forgot that rebasing with Github UI doesn't sign the commits 🤦

@pmalek pmalek enabled auto-merge (squash) March 2, 2023 09:53
@pmalek pmalek merged commit f43ab17 into main Mar 2, 2023
@pmalek pmalek deleted the add-machine-type-to-gke-cluster-builder branch March 2, 2023 10:06
@pmalek pmalek mentioned this pull request May 29, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shaneutt shaneutt shaneutt left review comments

@czeslavo czeslavo czeslavo approved these changes

Assignees

@pmalek pmalek

Labels
area/feature New feature or request area/maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pmalek @shaneutt @czeslavo