Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] enable gke clusters from existing #67

Merged
merged 3 commits into from
Jul 29, 2021
Merged

[feat] enable gke clusters from existing #67

merged 3 commits into from
Jul 29, 2021

Conversation

shaneutt
Copy link
Contributor

  • chore: move gke var names into gke pkg
  • chore: refactor gke auth into discreet fn
  • feat: enable gke clusters from existing

Unblocks work going on in Kong/kubernetes-ingress-controller#1095

@shaneutt shaneutt added the area/feature New feature or request label Jul 29, 2021
@shaneutt shaneutt added this to the Backlog - General Improvements milestone Jul 29, 2021
@shaneutt shaneutt self-assigned this Jul 29, 2021
@shaneutt shaneutt requested a review from a team as a code owner July 29, 2021 16:13
@codecov-commenter
Copy link

Codecov Report

Merging #67 (380a640) into main (b38b45c) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #67   +/-   ##
=======================================
  Coverage   22.09%   22.09%           
=======================================
  Files           2        2           
  Lines         172      172           
=======================================
  Hits           38       38           
  Misses        133      133           
  Partials        1        1           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b38b45c...380a640. Read the comment docs.

@rainest rainest merged commit de600ed into main Jul 29, 2021
@rainest rainest deleted the existing-gke branch July 29, 2021 16:40
@shaneutt shaneutt linked an issue Jul 29, 2021 that may be closed by this pull request
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GKE Existing Cluster Loader
3 participants