Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(lib): check send payload length #28

Merged
merged 7 commits into from
May 17, 2023
Merged

fix(lib): check send payload length #28

merged 7 commits into from
May 17, 2023

Conversation

chronolaw
Copy link
Collaborator

@chronolaw chronolaw commented May 11, 2023 •
edited
Loading

KAG-1523

@chronolaw chronolaw linked an issue May 11, 2023 that may be closed by this pull request
Returns error if the payload exceeds the size limit when publish method is called #29
Closed
@liverpool8056
Copy link

Because the limitation check occurs inside the events lib, it is invisible to the client code, would it be better if there would be a way for the client code to know the specific limit that is returned with the error msg?

@chronolaw chronolaw marked this pull request as ready for review May 11, 2023 06:37
@chronolaw
Copy link
Collaborator Author

We will add a note in readme to tell the user this limitation.

@chronolaw chronolaw force-pushed the feat/add_payload_length_check branch from 0f55698 to 4d197a5 Compare May 12, 2023 01:57
liverpool8056
liverpool8056 approved these changes May 12, 2023
View reviewed changes
Copy link

@liverpool8056 liverpool8056 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chronolaw chronolaw changed the title feat(lib): check send payload length fix(lib): check send payload length May 15, 2023
@liverpool8056 liverpool8056 mentioned this pull request May 15, 2023
Closed
3 tasks
@chronolaw chronolaw merged commit dcdace7 into main May 17, 2023
@chronolaw chronolaw deleted the feat/add_payload_length_check branch May 17, 2023 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bungle bungle bungle approved these changes

@liverpool8056 liverpool8056 liverpool8056 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Returns error if the payload exceeds the size limit when publish method is called
3 participants
@chronolaw @liverpool8056 @bungle