Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

a tcp failure on an http(s) check should increment the http-failure count #30

Closed
Tieske opened this issue Sep 12, 2019 · 0 comments · Fixed by #55
Closed

a tcp failure on an http(s) check should increment the http-failure count #30

Tieske opened this issue Sep 12, 2019 · 0 comments · Fixed by #55

Comments

@Tieske
Copy link
Member

Tieske commented Sep 12, 2019

originated here: #28 by @onematchfox

currently if an http check is performed, and it fails on TCP, then the TCP failure is recorded but the HTTP one is not. If this is combined with ignoring the TCP failures, (tcp_failures = 0) then the healthchecker will never trip if TCP errors occur for an HTTP check.
Tieske added a commit that referenced this issue Sep 20, 2020
@Tieske
fix(tcp failure) disabling tcp check on http(s) checks is not allowed
4e9ed3a 
fixes #30
@Tieske Tieske mentioned this issue Sep 20, 2020
Merged
Tieske added a commit that referenced this issue Sep 20, 2020
@Tieske
fix(tcp failure) disabling tcp check on http(s) checks is not allowed
e7b819f 
fixes #30
Tieske added a commit that referenced this issue Sep 20, 2020
@Tieske
fix(tcp failure) disabling tcp check on http(s) checks is not allowed (…
7e1b338 
…#55)

fixes #30
AlinsRan referenced this issue in api7/lua-resty-healthcheck Jun 1, 2023
@Tieske @AlinsRan
fix(tcp failure) disabling tcp check on http(s) checks is not allowed (…
94524e1 
…Kong#55)

fixes #30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(tcp failure) disabling tcp check on http(s) checks is not allowed Kong/lua-resty-healthcheck
1 participant
@Tieske